Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dates_calc.0.0.7 #26738

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rmonat
Copy link
Contributor

@rmonat rmonat commented Oct 14, 2024

dates_calc.0.0.7

A date calculation library
A date calculation library, with exact operators to add a given
number of days to a date, and approximate operators to add months or
years.



🐫 Pull-request generated by opam-publish v2.3.0

@raphael-proust
Copy link
Collaborator

Are the test failures due to the mismatch of python version?

It works on some distros (e.g., arch with python 3.12) but not on others (e.g., debian with python 3.9).

#   File "/home/opam/.opam/5.2/.opam-switch/build/dates_calc.0.0.7/_build/default/lib_python/src/dates_calc/dates.py", line 43
#     match month:
#           ^
# SyntaxError: invalid syntax

Don't know if you want to do anything about it. I think it's ok to merge and expect users to manage their python environment (although I'd recommend documenting the requirement somewhere).

@rmonat
Copy link
Contributor Author

rmonat commented Oct 15, 2024

Are the test failures due to the mismatch of python version?

It works on some distros (e.g., arch with python 3.12) but not on others (e.g., debian with python 3.9).

#   File "/home/opam/.opam/5.2/.opam-switch/build/dates_calc.0.0.7/_build/default/lib_python/src/dates_calc/dates.py", line 43
#     match month:
#           ^
# SyntaxError: invalid syntax

Don't know if you want to do anything about it. I think it's ok to merge and expect users to manage their python environment (although I'd recommend documenting the requirement somewhere).

Yes, this is pattern matching introduced by a recent Python version > 3.9. I would be in favor of merging as-is please!

@yawaramin
Copy link
Contributor

@rmonat is there any reason to require conf-python-3 for this package? The functionality of the OCaml package does not depend on Python, if I understand correctly? If an OCaml/opam user wants to use the OCaml dates_calc library, they don't really need Python, right?

If so, I would suggest removing the Python dependency for submission to opam-repository and if the user needs to use the Python version of the package, they can install it using their Python tooling which they would need to manage anyway to ensure they have the required minimum version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants