Package portmidi.0.4 #28531
Package portmidi.0.4 #28531
Conversation
|
CI is failing with: I also noticed deprecation alerts about using |
|
Oh. Guess I neglected to force push the updated 0.4 tag. I did that now in my repo. Do I need to run |
mbacarella
force-pushed
the
opam-publish-portmidi.0.4
branch
from
7c365af to
a8d0d9a
Compare
packages/portmidi/portmidi.0.4/opam
Outdated
| "ctypes" {>= "0.13.0"} | ||
| "ctypes-foreign" |
There was a problem hiding this comment.
| "ctypes" {>= "0.13.0"} | |
| "ctypes-foreign" | |
| "ctypes" {>= "0.21.1"} | |
| "ctypes-foreign" {>= "0.21.1"} |
Since ctypes.0.21.1 it depends lock-step on the corresponding ctypes-foreign version (e.g. ctypes-foreign.0.21.1) using the {= version} constraint.
Adding the above suggestion thus avoids cursed lower bounds combinations such as the following, which is causing one of the CI failures:
- downgrade ctypes 0.23.0 to 0.22.0 [required by portmidi]
- downgrade ctypes-foreign 0.23.0 to 0.4.0 [required by portmidi]
...
#=== ERROR while compiling portmidi.0.4 =======================================#
# context 2.4.1 | linux/x86_64 | ocaml-base-compiler.5.2.1 | pinned(https://github.com/mbacarella/portmidi/archive/refs/tags/0.4.tar.gz)
# path ~/.opam/5.2/.opam-switch/build/portmidi.0.4
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p portmidi -j 255 @install
# exit-code 1
# env-file ~/.opam/log/portmidi-7-3107e9.env
# output-file ~/.opam/log/portmidi-7-3107e9.out
### output ###
# File "c/dune", line 17, characters 25-39:
# 17 | (libraries ctypes.stubs ctypes.foreign portmidi_c_type_descriptions))
# ^^^^^^^^^^^^^^
# Error: Library "ctypes.foreign" not found.
# -> required by _build/default/c/type_gen.exe
# -> required by _build/default/c/c_generated_types.c
# -> required by _build/default/c/c_generated_types.exe
# -> required by _build/default/c/portmidi_c_generated_types.ml
# -> required by
# _build/install/default/lib/portmidi/c_function_descriptions/portmidi_c_generated_types.ml
# -> required by _build/default/portmidi.install
# -> required by alias install
|
Beside the above lower-bounds failure I can see
The FreeBSD failure is curious because the workflow does install the FreeBSD system package underway: Finally, would you consider adding an |
|
I can make the ctypes constraint fix. @jmid I don't know about the FreeBSD issue. I don't have the bandwidth to look into it. Can we just disable the package for freebsd (and also windows)? |
Great, thanks! 🙏
I would just leave Windows as is. Leaving FreeBSD as is is perhaps also preferable. |
mbacarella
force-pushed
the
opam-publish-portmidi.0.4
branch
from
a8d0d9a to
0acb235
Compare
|
Alrighty, pushed the constraint changes and also ...
I set this to none since I expect to reject most requests in the future as I don't use this library and am out of the ocaml ecosystem for the time being. |
There was a problem hiding this comment.
Finally, would you consider adding an x-maintenance-intent entry?
I set this to none since I expect to reject most requests in the future as I don't use this library and am out of the ocaml ecosystem for the time being.
Thanks for your honesty - and still sharing the package here 🙏
The latest CI run agrees with the previous one and
- fails a
conf-gmp.1lower-bound check fixed in #28540 - fails two opam-2.0 runs, which can be ignored
- fails on FreeBSD, but now with a
Failed to get sources of portmidi.0.4: Download command failed) - fails on Windows to install
conf-libportmidi(which is currently unsupported)
LGTM, thanks!
portmidi.0.4Bindings to libportmidi
OCaml bindings to libportmidi
🐫 Pull-request generated by opam-publish v2.5.1