Conversation
xavierleroy
approved these changes
Feb 17, 2026
xavierleroy
left a comment
xavierleroy
left a comment
There was a problem hiding this comment.
Looks very good to me. Thank you!
edwintorok
approved these changes
Feb 17, 2026
Collaborator
|
The CI doesn't like something about the way the fixed version is declared. |
Member
Author
|
The events / fixed: unfortunately git (and osv-schema) doesn't allow to include the branch name as far as I can tell. (and whatever you put after |
Member
Author
|
Merging, we can always adjust this advisory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy to hear your feedback @nojb @xavierleroy @gasche @Octachron @OlivierNicole @yomimono @edwintorok @JustinTimperio
The two git commits where it is fixed are the 4.14 and 5.4 branch (5.5 and trunk will follow once they are merged)