Conversation
alexcos20
added
Status: DoNotMerge
downgrade to node 16
Changes: - rail every blockNum function args to slot, instead of revert - payout function never reverts - renamed to ERC20Template3 - events are storing slot, it will be easier to group it in subgraph - truval_submitted it's an enum now, instead of bool - removed external addMinter function - refactor soonest_block_to_predict (there is blockNo diff between get and actual prediction block) - added SettingChanged event
…t-and-splitter-contracts Add vesting wallet and splitter contracts
Feature/send OCEAN in barge
Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>
document templates
…hdraw_eth Collector: use proper way to send eth
…n_for_eoa check if basetoken is contract
The doc lines for "calc_()" functions were incorrect: they didn't mention fees, and one said "basetoken" when it should have said "datatoken". And, one had a small typo. Also: spacing on MIN_FEE, MAX_FEE, etc declarations was inconsistent. Fixded.
deploy Optimism
…r_from_owner Remove owner transfer of baseTokens on sellDT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP !!