-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting up cli interactive flow #71
Conversation
can you do a quick update on the environment vars, so we don't have provider, aquarius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
One small comment, as we are not using the createAsset
from SDK
This part:
ddo.services[0].files = await ProviderInstance.encrypt(
assetUrl,
chainId,
macOsProviderUrl || providerUrl
);
If the templateIndex is 4
we need to remove the files object from the ddo service (actually we need to set it to empty string, not null, due to schema validations)
Like this
if(templateIndex === 4){
ddo.services[0].files = ''
} else ...
Ok, thanks for letting me know. I'll adjust that. |
…o issue-70-interactive-publish-flow
@paulo-ocean I've updated it to set the files as an empty string for template index 4. Let me know if it's alright and I'll merge this |
go for it |
Fixes #70
Changes proposed in this PR:
To test (with barge):
export NODE_URL="http://127.0.0.1:8001"
). No need to set Aquarius or provider URL anymore.npm run build && npm run cli start
To test (with Oasis testnet):
export RPCS='{ "23295":{ "rpc":"https://testnet.sapphire.oasis.io", "chainId": 23295, "network": "sapphire-testnet", "chunkSize": 1000 }}'
export NODE_URL="http://127.0.0.1:8001"
). No need to set Aquarius or provider URL anymore.npm run build && npm run cli start