Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datasets on ComputeAsset, new start compute fn #1870

Draft
wants to merge 13 commits into
base: release_4.0
Choose a base branch
from
Draft

add datasets on ComputeAsset, new start compute fn #1870

wants to merge 13 commits into from

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Oct 31, 2024 •
edited
Loading

Fixes #1867 .

Changes proposed in this PR:

  • Support for C2D V2 , startCompute now has datasets merged with additionalAssets, add supports fileObject
  • refer to C2D Docker ocean-node#705
  • start free compute job support (startCompute changes)
  • signature support for initializeCompute

@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 31, 2024

Code Climate has analyzed commit e1c5194 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.6% (-1.0% change).

View more on Code Climate.

@alexcos20
Copy link
Member

can you change the commit target to https://github.com/oceanprotocol/ocean.js/tree/release_4.0 please ?
Release 4.0 will have a lot of breaking changes

@paulo-ocean paulo-ocean changed the base branch from main to release_4.0 November 6, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc will be requested when the pull request is marked ready for review mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 will be requested when the pull request is marked ready for review alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina will be requested when the pull request is marked ready for review mariacarmina is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

Assignees
No one assigned
Labels
Status: DoNotMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C2D V2 support - Add fileObject types
2 participants
@paulo-ocean @alexcos20