Attempt to support Spring Boot WebApplicationContext initialization and lookup #368
Conversation
…attempted before failure occurs
| { | ||
|
|
||
| private final Logger log = Logger.getLogger(SpringServiceEnricher.class); | ||
| private static ServletContext context; |
There was a problem hiding this comment.
What happens, if this class runs in a traditionally deployed war file in a servlet container?
If there were multiple applications deployed, the ServletContext instances could overwrite each other and possibly leak into the wrong application?
There was a problem hiding this comment.
You mean in Servlet Container where someone has put shared dependencies in the servlet container classpath? Or in an EAR type container where JARs and dependencies are shared between WARs? I guess that could be a concern. Let me think about that. Good question.
Though I think a traditional WAR deployment where dependencies are provided in each WAR should not have any issues since each would have their own copy of the class files, unless I've forgotten how those work entirely.
Each WAR should have its own ClassLoader instance that should have the same parent AFAIK. (Unless it's a modular-classloaded servlet container, at which point neither would share a parent and they'd all be entirely independent, more or less.)
There was a problem hiding this comment.
This is exactly what I mean. "Simple" war deplyoments should be fine, when every war brings its own copy of rewrite which gets loaded by a dedicated classloader.
In more complex scenarios with some sort of shared classloading (EAR with jars and wars, or rewrite being deployed into the servlet-container itself) however, the static field could be a problem.
There was a problem hiding this comment.
Ok glad we are on the same page. I wasn't thinking of those use-cases since they aren't very common anymore, but I think you're right that they should be handled regardless. I'll work on it. Now that we have a framework for how to make this function it shouldn't be too hard. Any ideas are welcome :)
| import org.springframework.web.context.support.SpringBeanAutowiringSupport; | ||
|
|
||
| /** | ||
| * {@link ServiceEnricher} implementation for Spring. | ||
| * | ||
| * @author Christian Kaltepoth | ||
| */ | ||
| public class SpringServiceEnricher implements ServiceEnricher | ||
| public class SpringServiceEnricher implements ServiceEnricher, ContextListener |
There was a problem hiding this comment.
With this setup, the SpringServiceEnricher will be instantiated twice, won't it? Once as ServiceEnricher and once as ContextListener
There was a problem hiding this comment.
Yes, but only one of them would be used as an Enricher. The other would just handle the static. I could split this into a different ContextListener implementation, and try to deal with the EAR / shared lib classloader issue there.
|
@larsgrefer Ok. Updated with what I think should resolve the issue. Let me know your thoughts! Actually I do have some concerns about part of this due to the fact that Threads might be re-used between ServletContexts depending on how containers do initialization, but interested in your thoughts. |
|
Dangit. I did not mean to close this by renaming the branch. Working on a fix. |
Fixes #362