Merge pull request #13 from ocsf/allow-int-to-long

Allow int to long
ocsf · Jul 30, 2024 · e010f8a · e010f8a
2 parents 3c6b8a0 + 1303344
commit e010f8a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/ocsf/validate/compatibility/changed_type.py b/src/ocsf/validate/compatibility/changed_type.py
@@ -37,6 +37,8 @@ def validate(self, context: ChangedSchema) -> list[Finding]:
                 for attr_name, attr in event.attributes.items():
                     if isinstance(attr, ChangedAttr):
                         if isinstance(attr.type, Change):
+                            if attr.type.before == "integer_t" and attr.type.after == "long_t":
+                                continue
                             findings.append(
                                 ChangedTypeFinding(
                                     OcsfElementType.EVENT, name, attr_name, attr.type.before, attr.type.after
@@ -48,6 +50,8 @@ def validate(self, context: ChangedSchema) -> list[Finding]:
                 for attr_name, attr in obj.attributes.items():
                     if isinstance(attr, ChangedAttr):
                         if isinstance(attr.type, Change):
+                            if attr.type.before == "integer_t" and attr.type.after == "long_t":
+                                continue
                             findings.append(
                                 ChangedTypeFinding(
                                     OcsfElementType.OBJECT, name, attr_name, attr.type.before, attr.type.after

diff --git a/tests/ocsf/validate/compatibility/test_changed_type.py b/tests/ocsf/validate/compatibility/test_changed_type.py
@@ -36,3 +36,25 @@ def test_changed_type_object():
     findings = rule.validate(s)
     assert len(findings) == 1
     assert isinstance(findings[0], ChangedTypeFinding)
+
+def test_int_to_long():
+    """Test that changing an int to a long is allowed."""
+    s = ChangedSchema(
+        objects={
+            "process_activity": ChangedObject(
+                attributes={
+                    "process_name": ChangedAttr(type=Change("integer_t", "long_t")),
+                }
+            ),
+        },
+        classes={
+            "process_activity": ChangedEvent(
+                attributes={
+                    "process_name": ChangedAttr(type=Change("integer_t", "long_t")),
+                }
+            ),
+        }
+    )
+    rule = NoChangedTypesRule()
+    findings = rule.validate(s)
+    assert len(findings) == 0