ppx_js: clean-up #2120
Open
ppx_js: clean-up #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simpler code + make sure we don't lose any existing attribute.
Use Ast_builder.Default.pexp_fun, which takes care of extending a function with an additional parameter.
hhugo
reviewed
Oct 28, 2025
| let params = | ||
| { pparam_desc = | ||
| Pparam_val (nolabel, None, Pat.var ~loc:gloc (mknoloc name)) | ||
| ; pparam_loc = { fun_.pexp_loc with loc_ghost = true } |
There was a problem hiding this comment.
The loc is changed from fun_.pexp_loc to gloc (aka. !default_loc). Can you make sure this is fine ?
There was a problem hiding this comment.
I think this fun_.pexp_loc comes from the parameter ~loc:glob on line 831.
hhugo
reviewed
Oct 28, 2025
vouillon
force-pushed
the
ppx-fix
branch
2 times, most recently
from
6fe001d to
4027779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.