Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 4: Use of externally-controlled format string #4

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

octobooth-1
Copy link
Collaborator

Fixes https://github.com/octobooth/mona-gallery/security/code-scanning/4

To fix the problem, we should avoid using the user-provided id directly in the format string. Instead, we can use a placeholder (%s) in the format string and pass the id as an argument. This ensures that any format specifiers in the id are not interpreted by the System.out.format method.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

octobooth-1 and others added 3 commits October 29, 2024 12:17
…ring

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…led sources

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant