Skip to content

Make --submission-service optional#72

Closed
dra27 wants to merge 1 commit intoocurrent:masterfrom
dra27:optional-submission
Closed

Make --submission-service optional#72
dra27 wants to merge 1 commit intoocurrent:masterfrom
dra27:optional-submission

Conversation

@dra27
Copy link
Copy Markdown
Contributor

@dra27 dra27 commented Nov 12, 2020

Split off from #65, as it's not related.

@avsm
Copy link
Copy Markdown
Member

avsm commented Nov 13, 2020

Isn't it better to make this an option type and to do a local docker build instead of Current_ocluster.Raw.build_and_push (in src/pipeline.ml)? Making a fake uri like this will just make the local pipeline fail.

@dra27
Copy link
Copy Markdown
Contributor Author

dra27 commented Nov 13, 2020

In this instance, the pipeline failing is the "desired" outcome - I was seeking to update the tutorial where what you're after is simply the graph of what will be built (everything up to "However, before going further you will need to configure the builders." in the README)

@talex5
Copy link
Copy Markdown
Contributor

talex5 commented Nov 18, 2020

Alternative suggestion: provide a docker-compose.yml that brings up the base image builder and a local OCluster scheduler. The pipeline can connect to that without showing any errors, but the builds will just wait because there are no workers. But the user can later connect their own workers to it if they want to try building.

@talex5
Copy link
Copy Markdown
Contributor

talex5 commented Dec 1, 2020

I've added a docker-compose file in #82 as suggested. It should now be possible to see the graph and also to run builds easily.

@talex5 talex5 closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants