Merge pull request #58 from alexWorkArhs/fix-EuiccManager-check

changed check to be version P and moved initMgr for after the check
odemolliens · Oct 10, 2023 · ea94166 · ea94166
2 parents 67f6060 + ba573f2
commit ea94166
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -171,6 +171,11 @@ SimCardsManagerModule.setupEsim({
 
 ## Changelog
 
+### 1.0.18
+
+- **Fix** fix setupEsim. check for OS version P or above, before continuing and return if below. 
+- Moved initMgr() to after the version check.
+
 ### 1.0.12 & .13 & .14 & .15 & .16 & .17
 
 - **Fix** npm package; missing index.ts file

diff --git a/android/src/main/java/com/reactnativesimcardsmanager/SimCardsManagerModule.java b/android/src/main/java/com/reactnativesimcardsmanager/SimCardsManagerModule.java
@@ -178,11 +178,14 @@ private boolean checkCarrierPrivileges() {
   @RequiresApi(api = Build.VERSION_CODES.P)
   @ReactMethod
   public void setupEsim(ReadableMap config, Promise promise) {
-    initMgr();
-    if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.LOLLIPOP_MR1) {
+
+    if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.P) {
       promise.reject("0", "EuiccManager is not available or before Android 9 (API 28)");
+      return;
     }
 
+    initMgr();
+
     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P && mgr != null && !mgr.isEnabled()) {
       promise.reject("1", "The device doesn't support a cellular plan (EuiccManager is not available)");
       return;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-sim-cards-manager",
-  "version": "1.0.17",
+  "version": "1.0.18",
   "description": "react-native-sim-cards-manager description",
   "main": "index.js",
   "types": "types/index.d.ts",