-
Notifications
You must be signed in to change notification settings - Fork 116
[IMP] account: add a column for invoice status on the invoice list view and a 'sent' search filter #4867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0-rd-accounting-onboarding-malb
Are you sure you want to change the base?
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
281cbba to
09d5836
Compare
malb-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things and the task id 😄
| if move.is_move_sent: | ||
| move.is_move_sent_label = "Sent" | ||
| else: | ||
| move.is_move_sent_label = "Not Sent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one line this 😄
| tracking=True, | ||
| help="It indicates that the invoice/payment has been sent or the PDF has been generated.", | ||
| ) | ||
| is_move_sent_label = fields.Char(string="Invoice Sent", compute="_compute_is_move_sent_label") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to use a selection field don't you think 👀
| tracking=True, | ||
| help="It indicates that the invoice/payment has been sent or the PDF has been generated.", | ||
| ) | ||
| is_move_sent_label = fields.Char(string="Invoice Sent", compute="_compute_is_move_sent_label") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also rule of thumb for the quotes, use double quotes for what the user will see and single for the rest 😄
| decoration-success="is_move_sent" | ||
| decoration-danger="not is_move_sent" | ||
| optional="hide" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the filter not_sent, might be nice to add one for sent also 👀
…ew and a 'sent' search filter It would be easier for the user to see which invoices are sent or not in his list view, so a column was added to show which invoices were sent and which were not, also a filter for the 'not sent' invoices was in the search view but there was no filter for 'sent' invoices, that was added as well. task-5231300
09d5836 to
602f3ff
Compare
… status