Skip to content

Conversation

@yagho-odoo
Copy link

… status

@robodoo
Copy link

robodoo commented Nov 5, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

@yagho-odoo yagho-odoo force-pushed the 18.0-accountingOnboarding-sent-status-of-invoice-yagho branch from 281cbba to 09d5836 Compare November 6, 2025 08:37
@yagho-odoo yagho-odoo changed the title [IMP] account: added a label on the list view to show invoice sending… [IMP] account: add a label on the invoice list view to show sending status Nov 6, 2025
Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things and the task id 😄

Comment on lines 772 to 775
if move.is_move_sent:
move.is_move_sent_label = "Sent"
else:
move.is_move_sent_label = "Not Sent"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line this 😄

tracking=True,
help="It indicates that the invoice/payment has been sent or the PDF has been generated.",
)
is_move_sent_label = fields.Char(string="Invoice Sent", compute="_compute_is_move_sent_label")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to use a selection field don't you think 👀

tracking=True,
help="It indicates that the invoice/payment has been sent or the PDF has been generated.",
)
is_move_sent_label = fields.Char(string="Invoice Sent", compute="_compute_is_move_sent_label")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rule of thumb for the quotes, use double quotes for what the user will see and single for the rest 😄

decoration-success="is_move_sent"
decoration-danger="not is_move_sent"
optional="hide"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the filter not_sent, might be nice to add one for sent also 👀

…ew and a 'sent' search filter

It would be easier for the user to see which invoices are sent or not in his list view, so a column was added
to show which invoices were sent and which were not, also a filter for the 'not sent' invoices was in the search view
but there was no filter for 'sent' invoices, that was added as well.
task-5231300
@yagho-odoo yagho-odoo force-pushed the 18.0-accountingOnboarding-sent-status-of-invoice-yagho branch from 09d5836 to 602f3ff Compare November 10, 2025 12:37
@yagho-odoo yagho-odoo changed the title [IMP] account: add a label on the invoice list view to show sending status [IMP] account: add a column for invoice status on the invoice list view and a 'sent' search filter Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants