Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Inventory: Rewrite aging report as stock valuation report #11720

Closed
wants to merge 1 commit into from

Conversation

benderliz
Copy link
Contributor

This doc has been rewritten to address the following:

  • The Inventory Aging Report doc is no longer needed because this report was combined into the Stock Valuation Report (in the pivot view).
  • The Stock Valuation Report, by default, is in list view. This doc overwrites the Inventory Aging Report to instead focus primarily on the Stock Valuation Report list view, including all the updated/new fields shown in this view.
  • Parts of the former Inventory Aging Report are still covered in the Stock Aging Report section.
  • A section was added to described the graph view of this report.
  • A few other sections were added to describe important contextual information about stock valuation and how it is calculated (e.g. perpetual vs. periodic accounting, SVLs)

Odoo Project task # 4320416

@robodoo
Copy link
Collaborator

robodoo commented Jan 9, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 9, 2025 21:54
@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch from 48ae564 to dd4777c Compare January 9, 2025 21:57
@benderliz benderliz requested a review from dikd-odoo January 9, 2025 21:58
@benderliz
Copy link
Contributor Author

Hi @dikd-odoo! This PR is ready for a first-round peer review. Thank you! 👯

@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch 2 times, most recently from 9406e8c to 5af908d Compare January 9, 2025 22:45
@benderliz
Copy link
Contributor Author

Hi @dikd-odoo! This PR is ready for a first-round peer review. Thank you! 👯

Hi @dikd-odoo - I am noticing a lot of little rendering issues in the runbot. Please hold off on this...will try to resolve these now and push up a new commit! Stay tuned B)

@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch from 5af908d to 4a76a4e Compare January 9, 2025 23:43
@benderliz
Copy link
Contributor Author

Note to @dikd-odoo and to self - I see in the runbot I need to edit the graph icon's guilabel! image

Copy link
Contributor

@dikd-odoo dikd-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benderliz phenomenal job on this PR! This was a solid breakdown of Stock valuation reports, something I had no idea about going into my review but can now confidently pull and configure in Odoo. The flow worked perfectly as stated, so most of my suggestions are content-based and have to do with matching the format and writing style that I've seen so far in the documentation. Once you've taken a look at these (optional) edits, this is ready to move to final review.

@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch from 4a76a4e to 5696913 Compare January 14, 2025 19:27
@benderliz benderliz requested a review from Felicious January 14, 2025 19:48
@benderliz
Copy link
Contributor Author

Hi @benderliz phenomenal job on this PR! This was a solid breakdown of Stock valuation reports, something I had no idea about going into my review but can now confidently pull and configure in Odoo. The flow worked perfectly as stated, so most of my suggestions are content-based and have to do with matching the format and writing style that I've seen so far in the documentation. Once you've taken a look at these (optional) edits, this is ready to move to final review.

Hi @dikd-odoo thank you SO much for this exemplary review! I really appreciated your stylistic suggestions and implemented many of them. The reminder of the doc structure (definition -> use case -> implementation) was really helpful as well. I learned a lot from you!

Tagging @Felicious for final review!

@Felicious Felicious added the 5 label Jan 17, 2025
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful document, @benderliz!

This is such a comprehensive and easy-to-understand explanation of a complex topic. The way you structured the information and provided detailed yet concise explanations of inventory valuation, accounting methods, and stock move lines was truly impressive. Your engaging writing made this a joy to read!

I'm so proud of the work you've done here. I left a few comments for you to review—feel free to consider them if they add value or provide relevant business context or Odoo software details.

I noticed you missed adding the points tag in the label, so I assigned it for you. (Just a reminder for next time—we don’t want you to miss out on credit for your amazing work!) Normally, I’d assign 3 points for a content rework, but since you introduced essential explanations about SVLs not covered elsewhere and expanded on the inventory valuation dashboard, this deserves a full ✨ 5 points ✨. You've breathed new life into the inventory aging report doc, creating a fantastic resource for customers learning about inventory valuation.

Next steps: Let's review the other two inventory valuation docs— Using Inventory Valuation and Automatic Inventory Valuation —to address duplicate information and incorporate feedback from a Belgium expert. I’ll share updates soon.

Amazing job, Liz—keep up the fantastic work! 🎉❤️

@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch from 5696913 to 76841c0 Compare January 17, 2025 18:57
@benderliz
Copy link
Contributor Author

Wonderful document, @benderliz!

This is such a comprehensive and easy-to-understand explanation of a complex topic. The way you structured the information and provided detailed yet concise explanations of inventory valuation, accounting methods, and stock move lines was truly impressive. Your engaging writing made this a joy to read!

I'm so proud of the work you've done here. I left a few comments for you to review—feel free to consider them if they add value or provide relevant business context or Odoo software details.

I noticed you missed adding the points tag in the label, so I assigned it for you. (Just a reminder for next time—we don’t want you to miss out on credit for your amazing work!) Normally, I’d assign 3 points for a content rework, but since you introduced essential explanations about SVLs not covered elsewhere and expanded on the inventory valuation dashboard, this deserves a full ✨ 5 points ✨. You've breathed new life into the inventory aging report doc, creating a fantastic resource for customers learning about inventory valuation.

Next steps: Let's review the other two inventory valuation docs— Using Inventory Valuation and Automatic Inventory Valuation —to address duplicate information and incorporate feedback from a Belgium expert. I’ll share updates soon.

Amazing job, Liz—keep up the fantastic work! 🎉❤️

Felicia, thank you SO much for the detailed review!! Your comments helped me see a few things from a more user-centric standpoint (like the valuation date change section) and also reminded me of some Odoo conventions (I actually wasn't aware of the purpose of the RST abbreviations convention; now I know to use that!) ❤️ Thanks also for assigning points - still need to get in the habit of doing these things to track my work.

I think this doc is looking great and will hopefully help some inventory managers! :)

I see Sam is out today. Is there someone else who can do tech review, or will this need to wait til next week?

Thank you!

@benderliz benderliz self-assigned this Jan 17, 2025
@benderliz
Copy link
Contributor Author

Hi @StraubCreative! Felicia advised me that, since Sam is out, you can do a more tech-focused review of this PR? She and Dina did a great job peer reviewing, so hopefully this one isn't too time intensive. Thank you!

@benderliz benderliz requested review from samueljlieber and removed request for StraubCreative January 21, 2025 21:18
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benderliz! Great work on the overhaul of this doc! I have a couple technical changes I caught in my review. Please address these, and double check the formatting of the doc in the built html after the checks pass. Approving now, thank you for your work!
.....
@robodoo delegate=benderliz

@benderliz benderliz force-pushed the 18.0-inventory-valuation-report-beli branch from 76841c0 to 401415a Compare January 23, 2025 17:50
@benderliz
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants