[IMP] util/fields: Convert to company dependent without company field #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aj-fuentes
reviewed
Sep 4, 2025
|
upgradeci retry with always only base |
|
Can you add a test? |
filisbits
force-pushed
the
master-fields-allownocompanyfieldincompanydependent-agcb
branch
from
0dc8bd3 to
f131338
Compare
aj-fuentes
force-pushed
the
master-fields-allownocompanyfieldincompanydependent-agcb
branch
from
f131338 to
c1698c8
Compare
|
I rebased and pushed a fixup for the test to avoid reading the whole JSON data back |
aj-fuentes
force-pushed
the
master-fields-allownocompanyfieldincompanydependent-agcb
branch
2 times, most recently
from
956d79b to
5a0bd07
Compare
aj-fuentes
reviewed
Oct 1, 2025
src/base/tests/test_util.py
Outdated
Comment on lines
1195
to
1196
| # make the ORM re-read the info about these manual fields from the DB | ||
| self.registry._setup_models__(self.env.cr, ["res.partner"]) |
There was a problem hiding this comment.
With the help of @HydrionBurst this was the missing part to make the ORM reload the manual fields with the right metadata.
aj-fuentes
force-pushed
the
master-fields-allownocompanyfieldincompanydependent-agcb
branch
from
5a0bd07 to
85be83a
Compare
KangOl
reviewed
Oct 1, 2025
src/base/tests/test_util.py
Outdated
|
|
||
| # make the ORM re-read the info about these manual fields from the DB | ||
| if hasattr(self.registry, "_setup_models__"): | ||
| self.registry._setup_models__(self.env.cr) |
There was a problem hiding this comment.
Suggested change
| self.registry._setup_models__(self.env.cr) | |
| args = (["res.partner"],) if util.version_gte("saas~18.4") else () | |
| self.registry._setup_models__(self.env.cr, *args) |
There was a problem hiding this comment.
Done, a variant of this...
The current implementation of the function `_convert_field_to_company_dependent` requires a field that stores the company value, but this field is not always available. This change aims to allow that case by passing a falsy value as company_field, then it creates a json with the current value for all companies as the new value in the column
aj-fuentes
force-pushed
the
master-fields-allownocompanyfieldincompanydependent-agcb
branch
from
85be83a to
8372b21
Compare
KangOl
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the function
_convert_field_to_company_dependentrequires a field that stores the company value, but this field is not always available.This change aims to allow that case by passing a falsy value as company_field, then it creates a json with the current value for all companies as the new value in the column