Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to XDS <> FHIR metadata mappers #15

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

walcovanloon
Copy link
Collaborator

Resolve mapping issues in #14

  • XON <> Organization. XON can have an identifier without assigning authority if it is an OID.
  • XCN <> Practitioner. The code expects an assigning authority for the identifier. But either the name or the identifier is expected. So in case of a name-only XCN, the identifier does not need to be mapped. The rules for XCN are:
  • Assoc entryUuid might be empty on submission and then needs to be assigned by registry

* fix NPE for assoc.getEntryUuid
* fix NPE for legalAuthenticator without identifier
* fix NPE for organization without assigning authority
@walcovanloon walcovanloon linked an issue Oct 26, 2024 that may be closed by this pull request
@walcovanloon walcovanloon requested a review from Thopap October 26, 2024 19:45
@Thopap Thopap merged commit b7c925a into main Oct 27, 2024
3 checks passed
@walcovanloon walcovanloon deleted the 14-small-fixes-to-xds-fhir-metadata-mappers branch December 21, 2024 17:25
Comment on lines -398 to +399
var previousIdentifier = assoc.getEntryUuid();
if (assoc.getEntryUuid() == null || !assoc.getEntryUuid().startsWith(MappingSupport.UUID_URN)) {
assoc.assignEntryUuid();
var previousIdentifier = assoc.getEntryUuid();
Copy link

@ahpatrifork ahpatrifork Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walcovanloon @Thopap I know this pr is merged but doesn't this introduce an error?

previousIdentifier is initialized after assigning a new entryUuid, so you end up not replacing the associations' source and target uuids

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahpatrifork,

thank you for this review. You are right, this issue will cause that that the SS-HM associatin (as described in 4.2.2.1.5) might not be reflected correctly in the fhir request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small fixes to XDS <> FHIR metadata mappers
3 participants