Small fixes to XDS <> FHIR metadata mappers #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix NPE for assoc.getEntryUuid * fix NPE for legalAuthenticator without identifier * fix NPE for organization without assigning authority
Thopap
approved these changes
Oct 27, 2024
ahpatrifork
reviewed
Feb 21, 2025
Comment on lines
-398
to
+399
| var previousIdentifier = assoc.getEntryUuid(); | ||
| if (assoc.getEntryUuid() == null || !assoc.getEntryUuid().startsWith(MappingSupport.UUID_URN)) { | ||
| assoc.assignEntryUuid(); | ||
| var previousIdentifier = assoc.getEntryUuid(); |
There was a problem hiding this comment.
@walcovanloon @Thopap I know this pr is merged but doesn't this introduce an error?
previousIdentifier is initialized after assigning a new entryUuid, so you end up not replacing the associations' source and target uuids
There was a problem hiding this comment.
Hi @ahpatrifork,
thank you for this review. You are right, this issue will cause that that the SS-HM associatin (as described in 4.2.2.1.5) might not be reflected correctly in the fhir request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve mapping issues in #14