Replacing instances of move == ttData.move with the new flag ss->isTTMove
#5857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bench: 3088494
|
I feel that this could introduce inconsistencies between moves loop heuristics and extension conditions. Any opinions from the maintainers? |
|
Should I rebase this to the new master, or is there something that prevents this change from being merged? |
|
I will close it, as the changes are included in the PR of another dev, #6007 , and merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isTTMoveflag was introduced to provide a cleaner and more direct way to check if the current move being considered originates from the TT. This PR aims to consistently utilize this flag where appropriate.Non-functional
bench: 3088494