Feature/summer2024 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some of the content went into various rst files in `docs/`
in the github action for building documentation, i got this:
```
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/sphinx/config.py", line 348, in eval_config_file
execfile_(filename, namespace)
File "/usr/local/lib/python3.8/site-packages/sphinx/util/pycompat.py", line 81, in execfile_
exec(code, _globals)
File "/github/workspace/docs/conf.py", line 42, in <module>
import markdown2canvas
File "/github/workspace/markdown2canvas/__init__.py", line 10, in <module>
logging.basicConfig(encoding='utf-8')
File "/usr/local/lib/python3.8/logging/__init__.py", line 1997, in basicConfig
raise ValueError('Unrecognised argument(s): %s' % keys)
ValueError: Unrecognised argument(s): encoding
make: *** [Makefile:20: html] Error 2
```
i don't think it was doing anything
this commit is BROKEN.
namespace is so much cleaner. added module level docstrings docstrings for most functions added all unit tests passed
…/markdown2canvas into feature/summer2024
Takes into account that there may be multiple instances of a given file in different folders if meta.json was changed and the previous instances were not deleted.
page is published before checking contents; style removed from generic style test to check default.
…/markdown2canvas into feature/summer2024
to make more clear that setting them does nothing. you have to call functions using them!
module namespaces are still clogged with things like `os` -- for example, `mc.canvas_objects.os`. The `os` there shouldn't make it out. But I'm running out of time to work on this.
Was using datetime, which caused a problem running in the evening (central). Didn't think the test was worth the trouble.
now provides defaults OUTSIDE the function, and the extensions are customizable via the defaults.json file they are NOT over-rideable per-object, though
…/markdown2canvas into feature/summer2024
also, adding references to other content, to touched `conf.py`
|
Completed. This should trigger a doc build for the Main version of the code, significantly improving the online documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit tests:
Refactor of code to be less monolithic.
Created documentation.