Fix IntegerArbitrary#shrink to respect min/max bounds #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traints This commit adds test cases that verify the shrink method respects the min/max range constraints. Currently these tests fail because shrink always converges to 0, ignoring the specified range boundaries. Issue: #35
Fixed an issue where IntegerArbitrary#shrink could produce values outside the specified min/max range constraints. Changes: - When target is not specified, use the closest value to 0 within bounds - Always clamp target to be within the valid range - Clamp intermediate values during shrinking to stay within bounds - Don't yield target if it equals the current value This ensures that for ranges like min:25, max:65, all shrunk values are guaranteed to be within the specified bounds. Fixes #13
Added entry for PR #36 that fixes the shrink method to respect min/max bounds in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IntegerArbitrary#shrinkto ensure all generated values stay within the specified min/max boundsProblem
The
shrinkmethod was generating values outside the specified range constraints. For example, withmin: 25, max: 65, it could produce values like0or-1, which violate the minimum bound.Solution
[min, max]Test plan
Fixes #35