fix validation

ohcnetwork · May 21, 2024 · 3cf9d34 · 3cf9d34
1 parent c2f22fc
commit 3cf9d34
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/care/facility/api/serializers/patient_consultation.py b/care/facility/api/serializers/patient_consultation.py
@@ -548,7 +548,7 @@ def validate_create_symptoms(self, value):
 
         current_time = now()
         for obj in value:
-            if "onset_date" not in obj:
+            if not obj.get("onset_date"):
                 raise ValidationError(
                     {"onset_date": "This field is required for all symptoms"}
                 )
@@ -558,8 +558,8 @@ def validate_create_symptoms(self, value):
                     {"onset_date": "Onset date cannot be in the future"}
                 )
 
-            if "cure_date" in obj:
-                if obj["cure_date"] < obj["onset_date"]:
+            if cure_date := obj.get("cure_date"):
+                if cure_date < obj["onset_date"]:
                     raise ValidationError(
                         {"cure_date": "Cure date should be after onset date"}
                     )