-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Custom Migration to clean no input values as null in Daily Rounds table #1839
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1839 +/- ##
==========================================
- Coverage 61.95% 61.92% -0.04%
==========================================
Files 221 221
Lines 12170 12173 +3
Branches 1736 1739 +3
==========================================
- Hits 7540 7538 -2
- Misses 4324 4327 +3
- Partials 306 308 +2 ☔ View full report in Codecov by Sentry. |
The tasks are done just waiting for the confirmation from Aparna. Once the reply comes, then I will make the PR ready. |
@sainak Can you check the PR? |
care/facility/migrations/0408_alter_dailyround_consciousness_level_and_more.py
Outdated
Show resolved
Hide resolved
4142943
to
3a3e83e
Compare
care/facility/migrations/0414_alter_dailyround_consciousness_level_and_more.py
Outdated
Show resolved
Hide resolved
@sainak Can you check the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Bug Fix
Proposed Changes
Daily Rounds
having zero value tonull
Associated Issue
null
in Daily Rounds table #1810undefined
instead instead of colaescing it with 0 or -1 in some fields care_fe#6985Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins