Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Migration to clean no input values as null in Daily Rounds table #1839

Merged
merged 5 commits into from
Mar 17, 2024

Conversation

aeswibon
Copy link
Contributor

@aeswibon aeswibon commented Jan 20, 2024

Bug Fix

Proposed Changes

  • Migrated all fields of Daily Rounds having zero value to null
  • Migrated all blood pressure fields that are less than or equal to 0 to null

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.92%. Comparing base (2170b37) to head (47359c3).

Files Patch % Lines
care/facility/models/daily_round.py 55.55% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
- Coverage   61.95%   61.92%   -0.04%     
==========================================
  Files         221      221              
  Lines       12170    12173       +3     
  Branches     1736     1739       +3     
==========================================
- Hits         7540     7538       -2     
- Misses       4324     4327       +3     
- Partials      306      308       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeswibon
Copy link
Contributor Author

@aparnacoronasafe, Can you confirm whether zero can be a valid value in blood pressure fields?

#1810 (comment)

The tasks are done just waiting for the confirmation from Aparna. Once the reply comes, then I will make the PR ready.

@aeswibon aeswibon marked this pull request as ready for review January 22, 2024 13:25
@aeswibon
Copy link
Contributor Author

aeswibon commented Feb 9, 2024

@sainak Can you check the PR?

@aeswibon aeswibon force-pushed the issue#1810 branch 2 times, most recently from 4142943 to 3a3e83e Compare February 13, 2024 14:17
@aeswibon
Copy link
Contributor Author

@sainak Can you check the PR?

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sainak sainak requested review from Ashesh3 and rithviknishad March 1, 2024 12:19
@sainak sainak requested a review from vigneshhari March 5, 2024 05:27
@vigneshhari vigneshhari merged commit 257abe6 into ohcnetwork:develop Mar 17, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Migration to clean no input values as null in Daily Rounds table
4 participants