Skip to content

added timeout to middleware requests #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

praffq
Copy link
Contributor

@praffq praffq commented Sep 7, 2024

Proposed Changes

  • Added a timeout setting for middleware requests with default to 20 seconds

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@praffq
Copy link
Contributor Author

praffq commented Sep 7, 2024

updated

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.89%. Comparing base (a06913e) to head (1d071d3).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/assetintegration/base.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2434      +/-   ##
===========================================
+ Coverage    64.57%   64.89%   +0.31%     
===========================================
  Files          240      242       +2     
  Lines        13646    13806     +160     
  Branches      1950     1977      +27     
===========================================
+ Hits          8812     8959     +147     
- Misses        4460     4471      +11     
- Partials       374      376       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak marked this pull request as ready for review September 8, 2024 10:32
@sainak sainak requested a review from a team as a code owner September 8, 2024 10:32
@vigneshhari vigneshhari merged commit d36b5d9 into ohcnetwork:develop Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants