Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release v24.38.0 #2459

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Production Release v24.38.0 #2459

merged 6 commits into from
Sep 17, 2024

Conversation

nihal467
Copy link
Member

Proposed Changes

  • Brief of changes made.

Associated Issue

  • Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

sainak and others added 6 commits September 5, 2024 14:14
* added consent flows in abdm

* made patient_abha as a foriegn key field in consent

* renamed patient_health_id to patient_abha

* renamed patient_health_id to patient_abha

* added filterset class to consent

* send external_id as id in consent serializer

* resolved migration conflicts

* seperated out consent request and consent artefact

* get health information from hip

* decrypt data from abdm

* store health information in s3

* moved status from consent request to consent artefact

* display health information

* added patients find apis

* added consents__hiu__notify

* send push notification in patients/on-find

* fixed gateway api calls

* remove date range from health-information/cm/request

* added ratelimits to abdm m3 apis

* added status in consent request

* fix consent denied logic

* added facility filter to consent requests

* fixed a typo

* added patient_abha_object in consent request serializer

* fixed consent status update logic

* support retrieve hi docs by consent id

* added all the suggestions from review

* update migrations

* added date range to health_information__cm__request

* fixed reverse mapping of an enum REVERSE_CONDITION_VERIFICATION_STATUSES

* fix a type in health_id

* fix migration

* fix linting error

* added backend domain env

* removed https prefix while using BACKEND_DOMAIN

Co-authored-by: Aakash Singh <mail@singhaakash.dev>

* removed duplicate conditional logic

Co-authored-by: Aakash Singh <mail@singhaakash.dev>

* fix linting issues

* added patient field to abdm.abhanumber model

* remove abha_number field from facility.patientregistration model

* remove abdm references in the patient serializer

* remove abdm references (auto add care context on consultation create) in the consultation serializer

* removed an unused abdm import

* added related_name to patient field in abdm.abhanumber model

* add hasattr check while patient.abha_number and revert patient.abha_number to abha_number.patient while saving

* added consultation receiver to auto add care context on create

* added abha_number viewset and serializer

* remove abha number from patient model in dummy data

* resolve migration conflicts

* fix linting errors

* fixed migration reference

* Apply suggestions from code review

* resolve migration conflict

* use bulk update in reverse_patient_abhanumber_relation

* resolve migration conflict

* fix the migration logic abha_number not found on patient

* added validation errors

* replaced general exceptions with validation error

* fixed consent filters

* fix migration conflict

* fix dummy data

* revert dummy data changes

* remove abha_number field

* handle json decode errors for abdm responses

* use correct json exception

* fixed migration conflict

* check permission after filtering the query set in AbhaNumberViewSet retrieve

* resolve migration conflict

---------

Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: Khavin Shankar <khavinshankar@Khavins-MacBook-Air.local>
Merge Develop to Staging v24.38.0
@nihal467 nihal467 requested a review from a team as a code owner September 17, 2024 08:11
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 36.15385% with 83 lines in your changes missing coverage. Please review.

Project coverage is 64.13%. Comparing base (fd58b11) to head (1a3c4d3).
Report is 22 commits behind head on production.

Files with missing lines Patch % Lines
care/abdm/api/viewsets/healthid.py 8.51% 43 Missing ⚠️
care/abdm/api/viewsets/abha_number.py 60.00% 14 Missing ⚠️
care/abdm/service/request.py 7.69% 12 Missing ⚠️
care/abdm/utils/api_call.py 20.00% 4 Missing ⚠️
care/abdm/api/viewsets/consent.py 25.00% 3 Missing ⚠️
care/abdm/service/gateway.py 25.00% 3 Missing ⚠️
care/abdm/api/viewsets/auth.py 0.00% 2 Missing ⚠️
care/abdm/api/viewsets/health_information.py 0.00% 1 Missing ⚠️
care/abdm/api/viewsets/hip.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           production    #2459      +/-   ##
==============================================
+ Coverage       64.10%   64.13%   +0.03%     
==============================================
  Files             241      240       -1     
  Lines           13583    13585       +2     
  Branches         1944     1954      +10     
==============================================
+ Hits             8707     8713       +6     
+ Misses           4516     4513       -3     
+ Partials          360      359       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dauntlessnomad dauntlessnomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by @nihal467
okay to Merge.

@sainak sainak merged commit 9343820 into production Sep 17, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants