feat: Added validation for max dosage and corresponding test cases #2383

care/facility/api/serializers/prescription.py

@@ -9,6 +9,7 @@
     PrescriptionDosageType,
 )
 from care.users.api.serializers.user import UserBaseMinimumSerializer
+import re
 
 
 class MedibaseMedicineSerializer(serializers.ModelSerializer):
@@ -98,6 +99,13 @@ class Meta:
         )
 
     def validate(self, attrs):
+        def extract_numeric_value(dosage):
+
+            match = re.match(r"(\d+(\.\d+)?)", dosage)  # Matches digits and optional decimal part
+            if match:
+                return float(match.group(1))
+            raise serializers.ValidationError({"dosage": "Invalid dosage format."})
+
         if "medicine" in attrs:
             attrs["medicine"] = get_object_or_404(
                 MedibaseMedicine, external_id=attrs["medicine"]
@@ -127,6 +135,26 @@ def validate(self, attrs):
                 {"base_dosage": "Base dosage is required."}
             )
 
+            # Validate max_dosage is greater than or equal to base_dosage
+        base_dosage = attrs.get("base_dosage")
+        max_dosage = attrs.get("max_dosage")
+
+        if base_dosage and max_dosage:
+         try:
+            # Extract numeric values from dosage strings
+            base_dosage_value = extract_numeric_value(base_dosage)
+            max_dosage_value = extract_numeric_value(max_dosage)
+
+            # Raise error if max_dosage is less than base_dosage
+            if max_dosage_value < base_dosage_value:
+                raise serializers.ValidationError(
+                    {"max_dosage": "Max dosage in 24 hours should be greater than or equal to base dosage."}
+                )
+         except ValueError:
+            raise serializers.ValidationError(
+                {"dosage": "Dosages must be numeric values with optional units."}
+            )
+
         if attrs.get("dosage_type") == PrescriptionDosageType.PRN:
             if not attrs.get("indicator"):
                 raise serializers.ValidationError(

care/facility/tests/test_prescriptions_api.py

@@ -285,3 +285,32 @@ def test_medicine_filter_for_prescription(self):
             self.assertEqual(
                 prescription["medicine_object"]["name"], self.medicine.name
             )
+
+    def test_max_dosage_greater_than_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="1000 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+
+    def test_max_dosage_equal_to_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="500 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+
+    def test_max_dosage_less_than_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="400 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+        self.assertIn("max_dosage", response.data)
+        self.assertEqual(
+            response.data["max_dosage"][0],
+            "Max dosage in 24 hours should be greater than or equal to base dosage."
+        )