fix: Inventory unexpectedly marked as Low Stock #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sainak the min_quantity can stay and maybe FE can ignore the flag if the min_quantity value is not present, or we can add that logic into our flagging system. |
Sure I'll apply the changes |
|
@sainak in FE or BE ? |
|
Its possible to do it on the BE but the min_quantity will still be redundant atlest in |
|
@vigneshhari we can also rename the min_quantity field to default_min_quantity in the response and decide the is_low based on the |
|
yea sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the FacilityInventoryMinQuantity object is not present for an item it uses the value defined in the FacilityInventoryItem
so the fix would be to ignore the min value in FacilityInventoryItem and retire the min_quantity field
#725, ohcnetwork/care_fe#2437