Add missing i18n translations #10463
Conversation
WalkthroughThis pull request updates localization by adding and modifying several key-value pairs in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
….com/rajku-dev/care_fe into issue/10401/i18n-missing-translation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
public/locale/en.json (3)
716-716: Added Diagnosis Status Placeholder Key
The new key "diagnosis_status_placeholder" with the value "Select diagnosis status" provides a clear prompt for a dropdown input. Verify that its usage in the related UI components is consistent and unambiguous.
717-717: Added Diagnosis Verification Placeholder Key
The key "diagnosis_verification_placeholder" ("Select verification status") has been introduced to clarify user prompts in the diagnosis verification context. Ensure its proper integration in the form components and that it matches the intended use case.
1389-1389: New Key for No Locations Available
The new key "no_locations_available" with the value "No locations available" adds to the localization set. Please check that its usage is distinct from any similar keys (such as "no_locations_found") and fits the intended context accurately.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
public/locale/en.json(12 hunks)src/components/Questionnaire/QuestionTypes/DiagnosisQuestion.tsx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/Questionnaire/QuestionTypes/DiagnosisQuestion.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cypress-run (1)
🔇 Additional comments (8)
public/locale/en.json (8)
413-413: New i18n Key for Time Display
The new key "at_time" with the value "at {{time}}" adds HTML emphasis to the time variable. Ensure that components using this translation (likely via react-i18next’s component) safely render the HTML to prevent injection risks and display the intended formatting.
482-482: Updated Key for Attribution
The key "by_name" now definitively indicates its context by including HTML ("by {{by}}") and replaces a more ambiguous "by" value. This improves clarity in the UI. Please confirm that all components referencing this translation have been updated to use "by_name".
919-919: New Key for End Date
The addition of the key "end_date" with the value "End date" will help in forming consistent date labels throughout the application. Confirm that the UI elements consuming this key handle date formats appropriately and are consistent with related keys (e.g., "start_date").
1037-1037: Enhanced Filing Notification with HTML Emphasis
The new key "filed" now reads "filed {{title}}", using HTML to emphasize the title component. Ensure that any component rendering this string correctly processes the HTML markup without introducing security issues.
1296-1296: New Medication Error Notification Key
"medication_already_marked_as_error" has been added with a straightforward message. It is important that this message be used in context where a medication-related error is indicated and that it accurately guides the user.
1448-1448: New Key for Not Started Status
The introduced key "not_started" with the value "Not started" helps improve status labeling in the UI. It is concise and clear; ensure that it is used in contexts where a process is pending initiation.
1480-1480: New Key for Online Status
Adding "online" with the value "Online" enhances the localization for status indicators. Confirm that its usage aligns with other status keys and that the translation is applied uniformly across components reflecting online status.
1497-1497: New Organization Requirement Message
The newly added key "organization_required" returns "Organization is required". This message is clear for form validations. Verify that it is only used where the organization information is mandatory to prevent any potential user confusion.
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
|
@rajku-dev Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style