Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing i18n translations #10463

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rajku-dev
Copy link
Contributor

@rajku-dev rajku-dev commented Feb 7, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Expanded localization with additional interface texts, including new placeholders and error messages to enhance user guidance.
  • Style

    • Improved text formatting with emphasized translations for clarity.
    • Refined placeholder styling and adjusted label casing for a more consistent presentation.

@rajku-dev rajku-dev requested a review from a team as a code owner February 7, 2025 02:04
Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Warning

Rate limit exceeded

@rajku-dev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e48f5c and c81f746.

📒 Files selected for processing (1)
  • public/locale/en.json (13 hunks)

Walkthrough

This pull request updates localization by adding and modifying several key-value pairs in the en.json file. The changes include the insertion of new translation entries with embedded HTML formatting and adjustments to existing entries (e.g., updating the "by" key). Additionally, select React components have been updated to integrate the <Trans> component from react-i18next and refine UI text styling and casing, ensuring improved consistency in the user interface.

Changes

File(s) Change Summary
public/locale/en.json Added new translation keys (e.g., "end_date", "external_id", "verification_placeholder", and more) and modified existing keys to include HTML formatting (e.g., "by": "by <strong>{{by}}</strong>").
src/components/Facility/ConsultationDetails/QuestionnaireResponsesList.tsx Replaced the simple translation function (t) with the <Trans> component for dynamic content translation, enabling HTML element inclusion within translations.
src/components/Questionnaire/QuestionTypes/DiagnosisQuestion.tsx, src/components/Resource/PrintResourceLetter.tsx, src/pages/Facility/overview.tsx Adjusted UI text formatting: updated placeholder styling (wrapping in a styled <span>), modified text casing for labels (e.g., "From" to "from" and "Encounters" to "encounters").

Assessment against linked issues

Objective Addressed Explanation
Ensure all translation keys used in the UI are present in en.json (#10401)

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • rithviknishad
  • Jacobjeevan

Poem

I'm a rabbit who hops with glee,
Translating texts wide and free.
New keys and styles hop in the code,
Ensuring our UI lightens the load.
With every change, I cheer and play—
Bursting wit' joy, I nibble the day!
(__/), (•ㅅ•), /   づ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c81f746
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67a56c1182bdb40008804bd6
😎 Deploy Preview https://deploy-preview-10463--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -410,6 +410,7 @@
"assigned_facility": "Facility assigned",
"assigned_to": "Assigned to",
"assigned_volunteer": "Assigned Volunteer",
"at": "at <strong>{{time}}</strong>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"at": "at <strong>{{time}}</strong>",
"at_time": "at <strong>{{time}}</strong>",

@@ -478,7 +479,7 @@
"booked_by": "Booked by",
"bradycardia": "Bradycardia",
"breathlessness_level": "Breathlessness level",
"by": "By",
"by": "by <strong>{{by}}</strong>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"by": "by <strong>{{by}}</strong>",
"by_name": "by <strong>{{by}}</strong>",

@@ -2033,6 +2043,7 @@
"state": "State",
"state_reason_for_archiving": "State reason for archiving <strong>{{name}}</strong> file?",
"status": "Status",
"status_placeholder": "Select diagnosis status",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be confusing. key names should be specific to the context and usage. status alone is ambiguous.

Suggested change
"status_placeholder": "Select diagnosis status",
"diagnosis_status_placeholder": "Select diagnosis status",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing i18n Translation Keys Causing UI Inconsistencies
2 participants