Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tracking commits pushed to branch (core) #601

Open
wants to merge 161 commits into
base: activities
Choose a base branch
from

Conversation

rajku-dev
Copy link
Contributor

@rajku-dev rajku-dev commented Jan 9, 2025

Part of #373

kumar11jr and others added 30 commits April 10, 2024 19:57
* Configurable favicon.ico and logo.webp

* modified link

* fix: side navbar collapse on link click

* remove my comments made my me

* "fix:Scroll in Activity of user "
* hidden leaderboard filters in mobile view

* Added filter icon button
* initial commit

* issue page created using ActiveProject.tsx
* fix theme for footer

* upadate color of footer
* refactor: implemented dynamic import on /people route

* chore: removed useEffect in HoverCardWrapper

* chore: removed useEffect from import in HoverCardWrapper

* fix: small html fix
* experimental-commit-for-issue-forms

* reverse chnages in footer
* enable/disable features from env variables

* create featureIsEnabled function

* add typesafety

* update Readme

---------

Co-authored-by: Rithvik Nishad <mail@rithviknishad.dev>
* init

* fixes

* added cron jobs

* fixed routes

* lint fix

* comment envs

* fix url verification challenge not working

* some optimizations and support for showing manually added eod updates in app home

* adds missing general updates in eod channel updates

* Adds support for reacting to activity and clear updates message

* correct cron schedule for utc tz

* improve app home

* update env

* use consistent naming for envs

---------

Co-authored-by: rithviknishad <mail@rithviknishad.dev>
…eviews to avoid rate limit (ohcnetwork#439)

* improve message format

* log only errors

* optimize how reviews are pulled to avoid github's rate limit
* Added contrbutors OG image using genratemetadata

* convert css to tailwind css and change logo.webp to .jpg and creat symlink

* fix font url

* og image modified to opengraph-image.tsx

* merge conflicts and move opengraph-image.tsx to data repo

* revert the changes og-image.tsx keep on leaderboard repo

* revert the changes og-image.tsx keep on leaderboard repo

* logo.png delted

---------

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Copy link

netlify bot commented Jan 9, 2025

👷 Deploy request for leaderboard-develop pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 89594a7

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

How can i test the scraper for debugging? i can't run it on local machine?
@rithviknishad

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

There were two directions for each fetched Fork

  1. Fetch all its events and filter the PushEvent (REST event endpoint)
  2. Fetch all its branches and get their commit history (GraphQL)

i went with the second one for now.

@rithviknishad
Copy link
Member

Not a fan of N+1 approach. If this was deployed for a much bigger github org, which has too many forks, fetching commit history of each fork's branches might go off the limits pretty quickly.

Let's do a 2 part PR. Let's first get the org's repo commits tracked first. We can figure out something for the fork's. We only ideally care about commits pushed directly to default branch and commits pushed to PR branches alone.

@rajku-dev rajku-dev changed the title Add support for tracking commits pushed to branch Add support for tracking commits pushed to branch (core) Jan 10, 2025
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 10, 2025

Not a fan of N+1 approach. If this was deployed for a much bigger github org, which has too many forks, fetching commit history of each fork's branches might go off the limits pretty quickly.

Let's do a 2 part PR. Let's first get the org's repo commits tracked first. We can figure out something for the fork's. We only ideally care about commits pushed directly to default branch and commits pushed to PR branches alone.

I do agree with you, Please check this out #602 (comment)

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 15, 2025

Review is required in this PR, @rithviknishad
also the 2nd Part PR.
Please let me know if any changes are required.

@rithviknishad rithviknishad changed the base branch from main to activities February 19, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.