Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rana: Fixing #248 #262

Merged
merged 4 commits into from
Feb 1, 2022
Merged

rana: Fixing #248 #262

merged 4 commits into from
Feb 1, 2022

Conversation

einwickler
Copy link
Contributor

Fixes #248

I'm definitely no bash expert, so there may be a better solution to this. I took the idea of the ansi function in the agnoster theme.
See my comment in #248

@einwickler einwickler changed the title rana: Adressing #248 rana: Fixing #248 Nov 25, 2021
@akinomyoga
Copy link
Contributor

@einwickler Actually themes/colours.theme.sh, which is sourced from oh-my-bash.sh by default, already defines equivalent variables. I think it is better to update the PR to use these variables instead of directly defining the escape sequences inside rana.theme.sh. What do you think?

@akinomyoga akinomyoga merged commit 985edbc into ohmybash:master Feb 1, 2022
@akinomyoga
Copy link
Contributor

I've refactored and merged the PR. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange behavior with rana theme
2 participants
@einwickler @akinomyoga