Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token Response Attribute expires_in Should be Optional #439

Closed
yogeshbeniwal opened this issue Sep 15, 2022 · 1 comment · Fixed by #539
Closed

Token Response Attribute expires_in Should be Optional #439

yogeshbeniwal opened this issue Sep 15, 2022 · 1 comment · Fixed by #539
Assignees
@timnolte
Labels
bug good first issue hacktoberfest Small issues for those interested in participating in Hacktoberfest.
Milestone
3.10.1

Comments

@yogeshbeniwal
Copy link

Describe the bug
PHP warning message are shown in server error log with PHP 8.1

Screenshots
[error] 41977#41977: *167373 FastCGI sent in stderr: "PHP message: PHP Warning: Undefined array key "expires_in" in /daggerhart-openid-connect-generic/includes/openid-connect-generic-client-wrapper.php on line 700" while reading response header from upstream
@timnolte
Copy link
Collaborator

timnolte commented Sep 15, 2022 •
edited
Loading

Just noting that the real issue is that the tokens response expires_in attribute is defined as an optional attribute.

https://openid.net/specs/openid-connect-basic-1_0.html#TokenOK

expires_in
OPTIONAL. Expiration time of the Access Token in seconds since the response was generated.

@timnolte timnolte changed the title PHP Warning: Undefined array key "expires_in Refresh Token Attribute expires_in should be optional Sep 15, 2022
@timnolte timnolte self-assigned this Sep 15, 2022
@timnolte timnolte changed the title Refresh Token Attribute expires_in should be optional Token Response Attribute expires_in Should be Optional Sep 15, 2022
@timnolte timnolte added hacktoberfest Small issues for those interested in participating in Hacktoberfest. good first issue labels Oct 4, 2022
@timnolte timnolte added this to the 3.9.2 milestone May 24, 2023
@timnolte timnolte modified the milestones: 3.9.2, 3.10.1 Apr 25, 2024
@timnolte timnolte mentioned this issue May 7, 2024
Closed
3 tasks
timnolte added a commit that referenced this issue May 9, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
5ef802d 
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
@timnolte timnolte mentioned this issue May 9, 2024
Merged
6 tasks
@timnolte timnolte linked a pull request May 9, 2024 that will close this issue
fix(Wrapper): Fixes handling of optional expires_in attribute in Access Token #539
Merged
6 tasks
timnolte added a commit that referenced this issue May 9, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
5253c66 
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
timnolte added a commit that referenced this issue May 9, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
5f76cd6 
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
timnolte added a commit that referenced this issue May 10, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
523c21b 
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
timnolte added a commit that referenced this issue Jun 11, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
8386cbf 
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
timnolte added a commit that referenced this issue Jun 11, 2024
@timnolte
fix(Wrapper): Fixes handling of optional expires_in attribute in Ac…
1c34384 
…cess Token (#539)

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timnolte timnolte

Labels
bug good first issue hacktoberfest Small issues for those interested in participating in Hacktoberfest.
Projects
3.10.1 Bugfix Release
Status: Done
Milestone
3.10.1
2 participants
@timnolte @yogeshbeniwal