Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wrapper): Fixes handling of optional expires_in attribute in Access Token #539

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

timnolte
Copy link
Collaborator

@timnolte timnolte commented May 9, 2024

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Review Unit Tests.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

@timnolte timnolte requested a review from daggerhart as a code owner May 9, 2024 01:21
@timnolte timnolte linked an issue May 9, 2024 that may be closed by this pull request
@timnolte timnolte self-assigned this May 9, 2024
@timnolte timnolte added status: needs review PR that needs review. status: needs tests PRs that needs test coverage. labels May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Coverage report for commit: 8386cbf
File: clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 75.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
  50% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 5.15% | Methods: 6.25%
FilesLinesMethodsBranches
/workspaces/openid-connect-generic/includes
   functions.php-100.00%100.00%
   openid-connect-generic-client-wrapper.php4.42%4.00%100.00%
   openid-connect-generic-client.php--100.00%
   openid-connect-generic-login-form.php--100.00%
   openid-connect-generic-option-logger.php37.80%44.44%100.00%
   openid-connect-generic-option-settings.php47.37%12.50%100.00%
   openid-connect-generic-settings-page.php--100.00%
/workspaces/openid-connect-generic
   openid-connect-generic.php1.77%-100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@timnolte timnolte force-pushed the fix/439-optional-expires_in-attribute branch 3 times, most recently from 5f76cd6 to 523c21b Compare May 10, 2024 04:56
…cess Token

- Fixes #439
- Properly handles `expires_in` being OPTIONAl according to spec. (See: 3.2.2.5.  Successful Authentication Response)
@timnolte timnolte force-pushed the fix/439-optional-expires_in-attribute branch from 523c21b to 8386cbf Compare June 11, 2024 02:09
@timnolte timnolte merged commit 1c34384 into develop Jun 11, 2024
8 checks passed
@timnolte timnolte deleted the fix/439-optional-expires_in-attribute branch June 11, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR that needs review. status: needs tests PRs that needs test coverage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Response Attribute expires_in Should be Optional
1 participant