An update to the unittest workflow. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing CI and git workflows
mscho527
reviewed
Oct 21, 2024
.github/workflows/quemb_unittest.yml
Outdated
Comment on lines
51
to
56
| - name: Upload pytest html results | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: quemb-tests-coverage_${{ matrix.python-version }} | ||
| path: tests/htmlcov | ||
| if: always() |
There was a problem hiding this comment.
No artifacts are uploaded since code coverage is not activated. See annotations in a recent run.
mscho527
reviewed
Oct 21, 2024
| - name: Test with pytest | ||
| run: | | ||
| pytest | ||
| cd tests | ||
| pytest --doctest-modules --junitxml=junit/quemb-test-results_${{ matrix.python-version }}.xml |
There was a problem hiding this comment.
We don't have multiple python versions defined in the matrix (yet) so ${{ matrix.python-version }} is empty
|
Right! Added those missing bits so it should all be correct now. The codecov section is commented out but can still be there if someone wants to add it in the future. I've somewhat arbitrarily picked python versions 3.9, 3.10, and 3.11 to check for now. We can change these of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our workflow (
quemb_unittest.yml) to upload all artifacts generated throughout runningpytest.