-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An update to the unittest workflow. #46
Conversation
Testing CI and git workflows
.github/workflows/quemb_unittest.yml
Outdated
- name: Upload pytest html results | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: quemb-tests-coverage_${{ matrix.python-version }} | ||
path: tests/htmlcov | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No artifacts are uploaded since code coverage is not activated. See annotations in a recent run.
- name: Test with pytest | ||
run: | | ||
pytest | ||
cd tests | ||
pytest --doctest-modules --junitxml=junit/quemb-test-results_${{ matrix.python-version }}.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have multiple python versions defined in the matrix (yet) so ${{ matrix.python-version }}
is empty
Right! Added those missing bits so it should all be correct now. The codecov section is commented out but can still be there if someone wants to add it in the future. I've somewhat arbitrarily picked python versions 3.9, 3.10, and 3.11 to check for now. We can change these of course. |
Updates our workflow (
quemb_unittest.yml
) to upload all artifacts generated throughout runningpytest
.