-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: greptile-style review, pre-commit suggestions, rule engine fix #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Enhanced /matrix:review with Greptile-style output format - Confidence score (1-5), per-file analysis table - Critical issues, positive aspects sections - Pre-commit review suggestions for git/jj commits - Detects git commit and jj commit/describe/new - Non-blocking suggestion to run review first - Fixed rule engine integration in all hooks - PreToolUse:Edit, PreToolUse:Read, UserPromptSubmit - User-defined rules now properly evaluated - Deep research saves to session directory
|
Version files synced to 2.0.1 from CHANGELOG.md |
Release notes now show both current and previous version's changelog for better context when reading release notes.
Greptile OverviewGreptile SummaryAdds Greptile-style review output format with confidence scores and per-file analysis tables to Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Claude
participant PreToolBash as PreToolUse:Bash Hook
participant RuleEngine
participant CommitDetector as Commit Detector
participant PackageAuditor as Package Auditor
User->>Claude: Run command (e.g., "npm install pkg && git commit")
Claude->>PreToolBash: Intercept Bash tool
PreToolBash->>RuleEngine: STEP 1: Evaluate user rules
alt Rules block command
RuleEngine-->>PreToolBash: Blocked
PreToolBash-->>Claude: Deny execution
Claude-->>User: Show block message
else Rules allow command
RuleEngine-->>PreToolBash: Allowed/Warned
PreToolBash->>CommitDetector: STEP 2: Check for commit command
alt Is commit command
CommitDetector-->>PreToolBash: Commit detected
PreToolBash-->>Claude: Suggest review (exit 0)
Claude-->>User: Show review suggestion
Note over PackageAuditor: ❌ STEP 3 never reached<br/>Package audit bypassed
else Not commit command
CommitDetector-->>PreToolBash: Not a commit
PreToolBash->>PackageAuditor: STEP 3: Check for packages
alt Has packages to audit
PackageAuditor-->>PreToolBash: Critical CVEs found
PreToolBash-->>Claude: Ask user permission
Claude-->>User: Show security warning
else No packages
PackageAuditor-->>PreToolBash: Nothing to audit
PreToolBash-->>Claude: Allow execution
Claude-->>User: Execute command
end
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Summary
/matrix:reviewwith Greptile-style output format (confidence scores, per-file analysis)Key Changes
git commitandjj commit/describe/new, suggests running review first$CLAUDE_SESSION_DIRwith fallback to current directoryTest plan
/matrix:review stagedand verify Greptile-style output formatgit commitand verify suggestion message appearsjj commitand verify jj detection works/matrix:deep-researchand verify output location