-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: migrate commands to skills with hot-reload support #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all 10 Matrix slash commands to the new skills format: - Add user-invocable, context, agent, allowed-tools frontmatter - Use haiku for simple ops (doctor, reindex, list, export, warn, skill-candidates) - Use sonnet for complex ops (repomix, create-skill, deep-research, review) - Use context: fork for review and deep-research (isolated execution) - Add references/ for progressive disclosure on complex skills - Delete old commands/ directory Benefits: - Hot-reload: edit skills without restarting Claude Code - Cost savings: ~40-50% reduction from haiku for simple operations - Isolation: review/deep-research get fresh context via fork - Tool safety: explicit allowed-tools prevents unintended access
Contributor
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant Claude as "Claude Code"
participant HookSystem as "Matrix Hook System"
participant SkillLoader as "Skill Loader"
participant MatrixMCP as "Matrix MCP Server"
participant Database as "Matrix Database"
User->>Claude: "Submit prompt with skill trigger"
Claude->>HookSystem: "Trigger UserPromptSubmit hook"
HookSystem->>HookSystem: "Parse prompt for skill patterns"
HookSystem->>SkillLoader: "Load skill frontmatter and content"
SkillLoader->>SkillLoader: "Parse YAML frontmatter (agent, context, tools)"
HookSystem->>HookSystem: "Check allowed-tools permissions"
HookSystem->>Claude: "Inject skill context and instructions"
Claude->>MatrixMCP: "Execute allowed MCP tools"
MatrixMCP->>Database: "Query/store data as needed"
Database-->>MatrixMCP: "Return results"
MatrixMCP-->>Claude: "Tool execution results"
Claude->>User: "Display skill execution output"
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14 files reviewed, 1 comment
- Add v2.1.0 changelog entry for skills migration - Replace unclear $ARGUMENTS references with descriptive text - Address Greptile review comment about variable source
Contributor
|
Version files synced to 2.1.0 from CHANGELOG.md |
Owner
Author
|
Addressed Greptile review comments:
|
- Remove agent: sonnet from complex skills (use default opus) - Keep agent: haiku for simple delegation skills - Only specify context: fork where needed (review, deep-research) - Update changelog to reflect opus default with haiku delegation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user-invocable,context,agent,allowed-tools)haikufor simple operations,sonnetfor complex onescontext: forkfor review and deep-research (isolated execution)references/for complex skillsSkills Migration
Benefits
allowed-toolsprevents unintended accessTest plan
/skillsmenu