Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Remove Member' button is shown and makes error unexpectedly #1760

Closed
Silver-IT opened this issue Oct 11, 2023 · 1 comment · Fixed by #1764
Closed

'Remove Member' button is shown and makes error unexpectedly #1760

Silver-IT opened this issue Oct 11, 2023 · 1 comment · Fixed by #1764

Comments

@Silver-IT
Copy link
Member

Silver-IT commented Oct 11, 2023

Problem

Steps to reproduce

  • [Tab1] u1 signs up, and creates a group
  • [Tab2] u2 joins the group
  • [Tab3] u3 joins the group, and logs out
  • [Tab2] u2 creates a proposal to remove u3, DO NOT click 'Awesome' button at the last step
  • [Tab1] u1 approves the proposal
  • [Tab2] u2 still sees the proposal modal, and one more red button Remove Member. If u2 clicks this button, he gets error.
    image

Solution

Define the workflow and implement it

  • The modal should be closed as soon as the proposal is completed
  • The modal should not display Remove Member button

cc: @taoeffect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants