Remove member button is shown and makes error unexpectedly
#1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taoeffect, I selected the wrong target branch when create this PR. And the unnecessary pipelines should be removed. |
taoeffect
approved these changes
Oct 20, 2023
taoeffect
deleted the
1760-remove-member-button-is-shown-and-makes-error-unexpectedly
branch
Silver-IT
added a commit
that referenced
this pull request
Nov 13, 2023
* Fix issues with chatroom, move some key logic into selectors * Rename selector to isWaitingForKeyShare * fix: update description for group channels * WIP - Fix manifest not found error upon contract file change (#1703) * Fix manifest not found error on contract file change * Mark the gruntfile as WIP * Remove WIP tag and code duplication * Fix Chat UI bugs (#1712) * fix: error of scrolling outside of the ChatMain section * feat: jump to the latest when resize window * feat: jump to the latest message without any delay when resize window * fix: auto scroll 25 times a second * File attachment to chat - 1st chunk (#1694) * add file attachment button to the chat input-area el * dnd mixin skeleton * remove trailing space * create the image preview vue component. * task 1-2. create a preview file component for a non-image attachment * build 'File too large' modal and pop it out when size is too large * add a compressed svg image for attachment / make sure it can be colored via css * add links for the drag&drop references * display overlay image when chat-area is dragged over * hook up DnD behavior with file-attachements method * resolving some of Greg's CR * another chunk of work for Greg's CR * work on Greg's CR / multiple file attachments * fix the test failure * make it possible to append attachments when drag&drop is performed * resolve the linter error * work on Greg's CR / fix the bug where dot is displayed * Add signedData, change message format * Re-add validation * Fix flow errors * Fix OP_ATOMIC handling * Harmonise types for signedData and encryptedData * Proposal to update distribution date (#1643) * feat: created a DistributionDate modal * chore: improve translation * feat: updated translation and added isInFirstDistributionPeriod * feat: completed the change distribution date workfloww * feat: restrict group members to change group settings * feat: improve updateSettings group action * feat: exception handler when open proposal modal directly * fix: error to close General Proposal modal * feat: improve DistributionDate proposal workflow * feat: proposal Item for distribution date * feat: simplified interactive message templates * feat: proposal to change distribution date * fix: cypress error with distribution updates * feat: resolved feedback from @sebin * feat: test case for changing distribution date * fix: travis error regarding distribution date * fix: disable submit button instead of close proposal modal * fix: groupDistributionStarted using Date * feat: simplified * fix: init scrollDistance when switch channel * fix: simplified payment periods config * fix: updated translation * chore: remove DRY issue and update translation * feat: localized texts for proposals * Implement inner signatures for OP_KEY_REQUEST * Inner signatures for actions * Add wrapper to encryptedData result * Fix flow errors * Fix rotate keys error when content is undefined * Fix JSON serialization issues for incoming encrypted data * Reintroduce toJSON, fix issue with () * Use additional data for encryption * Start adding user keys to group & chatrooms * Add direction attribute to GIMessage * Add comment * Simplified some of the code relating to GIMessage and signedData * Fixed reference to headJSON * Rudimentary support for inner signatures (missing permissions) * Various changes: * Light refactoring of `encryptedAction` to make it clearer - Actions to own own identity do not use inner signatures * Permission checking and enforcement for inner signatures - Now, permissions are checked in a uniform way in a central location * Add new `ourContactProfilesById` and `ourContactsById` getters * Changes for optinally encrypting OP_KEY_* * Fix key re-selection issue * Should not display archived proposals from other group (#1723) * feat: destructure archPropData * chore: reverted style changes * chore: changed variable name * chore: added comments * Create ci.yml * Rethrow uncaught Vue errors in dev mode or CI (#1708) * Rethrow uncaught Vue errors in dev mode or CI * Apply review * WIP: Use encrypted OP_KEY_* and new OP_KEY_REQUEST * Bugfixes * Merge PrivateDM and GroupDM (#1709) * feat: direct messages in identity contract * feat: add/remove getters * feat: simplified getters * wip: merging privateDMs and groupDMs * fix: coding issues * feat: UI updates for the DMs with more than 3 * fix: add member to dm * feat: changed base branch from e2e-protocol-ricardo to e2e-protocol * fix: error in get dm by usernames * chore: added comments * fix: error in function parameters declaration * fix: inconsistent naming of members when create a new DM * fix: redundant message rendering issue * feat: grun tpin * chore: removed wrong version of contracts * feat: grunt pin:0.1.8 * feat: added comments * chore: removed changes in chelonia * chore: added comments * chore: fix typo * feat: error handling * chore: removed unnecessary comment * feat: improved chatroom types and added comments * feat: simplified getter * chore: simplified * chore: added comments, error handling * feat: merged DMs from inside and outside of the group * feat: remove workflow regarding the dm visibility * Bugfixes for new OP_KEY_SHARE * feat: remove notifications when leave group (#1722) * Bugfixes * Improvements & bugfixes chelonia.js: Use regular signedOutgoingData when possible group.js: Fix name of selector * Bugfixes * Bugfixes for UI error handling. Move encryptedOutgoingData into /keyDel and /keyUpdate * Implement some PR feedback * Make KRS+KR atomic; disable deleting state when logging out * Fix flow issues * Mark contract as dirty until keys are received * Bugfix: call group join upon login * Add comments * Encrypted storage * chore: resolved conflicts * feat: giCreateGroup waits until the user joins the group * chore: fixed some errors * fix: error egarding Awesome button disability * Mark contract as dirty until keys are received * Bugfix: call group join upon login * Add comments * feat: group-chat-direct-message.spec.js test passed * Remove event listener when logging out * Use settings for key storage instead of SessionStorage * Refactoring: state encryption logic * Simplify check * Update references to session storage with app settings * Support variable distribution period length (#1691) * Fix Vue error in groupProposalSettings * Remove unused paymentTotalFromUserToUser getter * Add groupSortedPeriodKeys getter in group.js * Update getters to support variable period length * Add isIsoString in time.js and use it * Support variable period length in MonthOverview.vue * Apply review * Add periodStampsForDate in time.js * Add getHistoricalPaymentPeriods in PaymentMixin.js * Rename getSortedPeriodKeys to getAllSortedPeriodKeys * Add a few comments * Export new helpers from time.js * Improve validation in periodStampsForDate * Remove occurences of 'undefined' * Fix missing break statement * Fix wrong getter name in SupportHistory.vue * fixup! Improve validation in periodStampsForDate * Restore logging in Cypress * Fix reactivity issue in MonthOverview.vue * Fix data() in PaymentRowReceived/Sent.vue * Use groupDistributionStarted i/o inWaitingPeriod * Revert change in updateDistributionDate * Use humanStart/DueDate in MonthOverview.vue * Simplify PaymentDetail.vue/initializeDetails * Use mounted i/o watch in PaymentRowReceived/Sent.vue * Fix pedantic Flow error * Pin contracts to 0.1.8 * Move mounted() near the top * Revert humanDate to plain import in MonthOverview.vue * Use payment.period to fix Invalid Date errors * Add .start field in initPaymentPeriod * Add .end field in in-memory payment periods * Rename getPeriodPayment to getPaymentPeriod * Fix issue 1739 * Pin contracts * Add test for payment in 2nd period * Fix conditions for omitting empty key ops * EncryptedValue: ensure that it's a string * Refactor: logout handler * Convert password to passwordFn to prevent logging * Fix issue (key rotation / private channel not working after rejoin) * Update Style-Guide.md Added `User-facing Strings Guide` * Update Style-Guide.md typo * Update Style-Guide.md Improved translation section * Update Style-Guide.md * Update Style-Guide.md * Update Style-Guide.md * Fix: leaving private chat without being member * Update Style-Guide.md fix typos * Documentation * feat: updated test cases according to the updated invitation workflow * Update Style-Guide.md Consistent use of colons * #1742 Use 'submit-button' component for asynchronous actions (#1750) * add a todo comment for future <submit-button /> replacement * add submit-button component to various places * work on Greg's CR * #1704 - Add 'Export to CSV' feature to payments table (#1724) * add export CSV button to the table * create ExportPaymentsModal.vue and register it * make sure all the UI side of work are ready * complete CSV Extraction logic * complete the download CSV file logic * fix the linter error * work on Greg's feedback on the button position * make sure 'Export CSV' button is not overlapped regardless of the screen width * fix the linter error * put all-period option into the dropdown * remove the unecessary extra padding * DRY PaymentsMixin.js * update for Greg's CR on the PR * fix the broken translation o the modal title * restore package.json wtf... * Bugfixes * Add UI prompt to login and re-order buttons * Rename button names * Bugfix: null inner signing key when leaving chatroom * Add comments explaining the innerSigning attributes * Bugfix: race condition when joining due to skipActionProcessing * Change bad previous head log level to warn * Remove skipActionProcessing from respondToKeyRequests * wip: second half * feat: added profile-card in payments table * [e2e-protocol] Fix the welcome screen bug in /pending-approval page (#1748) * render welcome screen as position:fixed in /pending-approval page * make the selector higher priority * Fixed error to save scroll position (#1730) * feat: direct messages in identity contract * feat: add/remove getters * feat: simplified getters * wip: merging privateDMs and groupDMs * fix: coding issues * feat: UI updates for the DMs with more than 3 * fix: add member to dm * feat: changed base branch from e2e-protocol-ricardo to e2e-protocol * fix: error in get dm by usernames * chore: added comments * fix: error in function parameters declaration * fix: inconsistent naming of members when create a new DM * fix: redundant message rendering issue * feat: grun tpin * chore: removed wrong version of contracts * feat: grunt pin:0.1.8 * feat: added comments * chore: removed changes in chelonia * chore: added comments * chore: fix typo * feat: error handling * chore: removed unnecessary comment * feat: improved chatroom types and added comments * feat: simplified getter * chore: simplified * chore: added comments, error handling * fix: error to save scroll position * chore: removed allowDMInvite * Bugfix: key rotation on watched contracts * Fix message format for OP_KEY_SHARE * Rotate PEK when a group member leaves * Generic definition for the various DB stores * Revert changes to frontend/model/database.js and use the identity contract ID as key * Remove withEnv * fix: error regarding passwordFn * bug-fix for closing modal reacting too slowly * Handle encrypted and unencrypted invites (accounting) * fear: remove archived data when leave the group (#1747) * Add return * Improvements to respondToKeyRequests * fix: errors in cypress test * Make sync no-op for existing contracts * fix: cypress issues * fix: error after login * Listen for login event before calling postSubmit * Await in the login form, documentation * Updates to postSyncOps * Split up syncContractAndWatchKeys * Add chelonia/private/enqueuePostSyncOps to blacklist * Closure for storeSecretKeys to prevent logging secrets * Remove promiseAllSettled. Bugfixes. * Update okturtles.eventqueue * Side-effects without await * Fix invocation * Make sure we sync any identity contracts we haven't synced upon login (#1763) * feat: sync missing identity contracts after joining group * chore: remove IIFE * chore: resolved feedback * Remove await on /out in internals.js * Remove queueInvocation for /out events * Make cannot leave if not a member error into a warning * Show login error prompt only for errors related to the identity contract itself * Fix issue of removing two members (error on second removal) * Update identity.js login logic, remove spurious sideEffect check * pin contracts * Implement a way to set default groupId (#1773) * feat: set default group ID which is successfully joined * fix: recovered package.json * Fix inability to join after sharer signs out * Updated login error message (#1731) * feat: make login error message more informative * chore: added a line to log error * fix: error of Member Removal (#1764) * Fix infinite re-subscription due to foreign keys * Revert "Updated login error message (#1731)" This reverts commit cf4b7f4. * Updated login error message (#1731) * feat: make login error message more informative * chore: added a line to log error * Fix undefined in vmInvites * preSendCheck for outgoing messages; move hooks to publishEvent * Remove preSendCheckContract * Remove await from call to leaveAllChatRoomsUponLeaving --------- Co-authored-by: Ricardo Iván Vieitez Parra <3857362+corrideat@users.noreply.github.com> Co-authored-by: Greg Slepak <contact@taoeffect.com> Co-authored-by: snowteamer <64228468+snowteamer@users.noreply.github.com> Co-authored-by: Sebin Song <songxevin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes