#2464 - Make emoji size slightly larger in the message text #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2464-emojis-are-small
|
| Run status |
|
| Run duration | 10m 16s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
112
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
reviewed
Dec 26, 2024
There was a problem hiding this comment.
Great work @SebinSong!
Question: Ricardo points out an interesting and rather frustrating fact that the emoji sizes aren't consistent across different platforms. So I'm just curious, to me 15% larger still looks a bit small, does it look fine for you? Or would 20% larger make sense?
|
@taoeffect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2464
[Fix screenshot - in Chrome]
Emojis in a message text will be detected and wrapped with
<span class='chat-emoji'></span>and then the font-size will be15%larger than the text-size (1.15em). Please let me know if we want it to be larger though.