Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift3 update #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Swift3 update #34

wants to merge 2 commits into from

Conversation

indrajitsinh
Copy link

Swift3

@ph1ps
Copy link

ph1ps commented Oct 3, 2016

@indrajitsinh I just noticed that there are already 4 PRs for Swift 3 support. Since the developer is inactive and probably won't accept the PRs, should we just remove this item from the list at https://github.com/vsouza/awesome-ios and add a fork of ours?
I'm just asking (also I'm assuming that you found that repository there) because it doesn't quite fit into the criteria at https://github.com/vsouza/awesome-ios/blob/master/.github/CONTRIBUTING.md.
Also I find it a real shame if this repository couldn't be used anymore without converting and fixing bugs. Maybe you could drop a opinion and I'm tagging you because you have the most recent PR. Thanks!

@seemakamath
Copy link

@indrajitsinh Please don't use the commits from my branch to open a new PR. There is another PR in progress already #30 that you should use (which is why I closed my PR in the first place).

@ph1ps
Copy link

ph1ps commented Oct 6, 2016

@seemakamath #30 is actually not a working build thats why I submitted #35 . Did you try building and running it?

@seemakamath
Copy link

@ph1ps Can you provide more details in terms of what's not working? Have you checked out this comment? #30 (comment)

@kiwo12345
Copy link

@seemakamath #30 does not work. Adding self.layoutIfNeeded() as mentioned in one of the comments will mess upp the constraints

@seemakamath
Copy link

@kiwo12345 Regardless, let's help get #30 merged by giving feedback there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants