Refactorization to manage multiple contracts#4
Open
tillkolter wants to merge 6 commits intookwme:masterfrom
Open
Refactorization to manage multiple contracts#4tillkolter wants to merge 6 commits intookwme:masterfrom
tillkolter wants to merge 6 commits intookwme:masterfrom
Conversation
Owner
|
@tillkolter is the identity observer just for the Haello app? |
Author
|
@okwme well, I needed it for my scenario, because I wanted to be informed when the account is "identified" to query more identity specific details from the contract. I thought this kind of pattern might be helpful for others as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the playground phase of my contribution for the Aeternity hackathon, I found myself with two contracts soon. I realised, that the current CLI only generated a javascript contract wrapper at a time, overwriting the last generation.
This could be easily fixed by removing the line in
DappScratch.writeWrapperwhich deleted the olddapp-scratch-wrapperfolder, but I also found, that having more than one contract, the initialisation part forweb3and the account initialisation should not be part of the contract wrapper class in a scenario that manages more than one contract, so I separated the contracts from the initialisation part and introduced a manager class, that manages the account related initialisation and instantiates the contracts.