This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Deis dash #12
Open
Deis dash #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 1, 2018 13:05
found 23 vulnerabilities (6 low, 15 moderate, 2 high)
144 packages, updated 57 packages and moved 3 packages in 18.122s fixed 23 of 23 vulnerabilities in 4808 scanned packages 5 package updates for 23 vulns involved breaking changes
upgrade to latest release
|
Hi @kingdonb sorry for the late reply. I'm no longer using Deis at work and don't have time to manage this project. Waiting for someone to take over to review this PR! |
|
That's OK! I've been continuing to learn NodeJS, thanks for the reminder about this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are still a nodejs wizard and you have time, would you be willing to review this set of changes?
I've updated deis dash for the latest nodejs and npm that I could get it to work on, and I upgraded all of the packages that npm audit complained about. I really don't know what I'm doing and I've managed to break all of the iconography and images, but it is still totally usable after the upgrades.
I'm just looking for someone who knows more about NodeJS than I do to tell me which of these changes make sense and which are nonsense. I got stuck with file-loader which kept telling me that emitFile was required, but this issue I found indicated that emitFile: false should have fixed that. It didn't, the only way I could get it to compile and run successfully was to comment out those images and break those links.
I'm really grabbing at straws at every part of this. I'm a Rails dev and NodeJS is not my strong suit.