-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rpi version #4
base: master
Are you sure you want to change the base?
Conversation
Congratulations |
Related to #1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work but you need to reduce hardcoded value.
See #3
Can you create a screenshot of the working bell docker on the |
Awesome @Dashlorde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dashlorde good job - added some change wishes
arm/bell/dockerfile
Outdated
|
||
RUN mkdir -p /app/server/src && \ | ||
apk add --update openssl && npm install express && \ | ||
wget -O BeLL-Apps-${version}.tar.gz \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed ...
arm/bell/dockerfile
Outdated
wget -O BeLL-Apps-${version}.tar.gz \ | ||
https://github.com/open-learning-exchange/BeLL-Apps/archive/${version}.tar.gz && \ | ||
tar xvf BeLL-Apps-${version}.tar.gz && \ | ||
mv BeLL-Apps-${version}/* /app/server/src/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... until here
arm/bell/server.js
Outdated
|
||
PortJack.get(/^(.+)$/, function(req, res) { | ||
|
||
res.setHeader('Location', 'http://' + HOST + ':2200/apps/_design/bell/MyApp/index.html') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please lets not use 2200 port
5984 is couchdb standard
@@ -0,0 +1,24 @@ | |||
FROM hypriot/rpi-node:6.10.0-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name of this file should be Dockerfile
not dockerfile
arm/db-init/couchdb-setup.sh
Outdated
fi | ||
|
||
# Default port for CouchDB accessed from host machine is 2200 | ||
PORT=${PORT:-2200} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use for default port 5984
arm/docker-compose-ready.yml
Outdated
couchdb: | ||
expose: | ||
- 5984 | ||
image: treehouses/rpi-couchdb:2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use old couchdb 1.6.1
arm/docker-compose-ready.yml
Outdated
- 5984 | ||
image: treehouses/rpi-couchdb:2.0.0 | ||
ports: | ||
- "2200:5984" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no 2200 just strait 5984
arm/docker-compose-ready.yml
Outdated
image: treehouses/rpi-couchdb:2.0.0 | ||
ports: | ||
- "2200:5984" | ||
- "2201:5986" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with couchdb 1.6.1 this line is not needed
@@ -0,0 +1,21 @@ | |||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in arm/docker-compose-ready.yml
@@ -0,0 +1,23 @@ | |||
FROM hypriot/rpi-node:6.10.0-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name of this file should be Dockerfile
not dockerfile
No description provided.