New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #1

Open

yaroslavprofi wants to merge 1 commit into olha-kaminska:master from yaroslavprofi:development

yaroslavprofi commented Oct 13, 2021

Hello, I saw you project and wanted to clean it up:

Major code cleanup; some constants (e.g. seeds) are in config.yaml
There were no spam.csv file, so you should upload it to data/ (I wrote myself this file)
You need to check for penalty in LogisticRegression, because only 'none' or 'l2' available. So the first estimation could be l2 as well
You did not use best_k for DecisionTreeClassifier, so i fixed it
You should generate requirements.txt for python packages installation


          notebook fixing

9c6007f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet