Open
Conversation
Collaborator
Author
|
All that is left here is to optimise the shader to run in two passes, horizontal and vertical. This would change the run time from O(n^2) to O(n) |
Run the filter in two passes, one horizontal and one vertical to go from O(N^2) performance to O(N)
Collaborator
Author
|
I think this is complete now @itsmattkc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dilate erode node to the filter category. Mainly useful for masks and other grey scale images.
Only controversial issue is that the Gaussian erode does an inversion via
1.0 - col.rgbwhich isn't really okay colour management wise. Is there a better way to do this? It may be okay in this case as this node will only really be used for masks or it may be better to wait until we have implemented an OCIO node so this operation can be done in screen space if required.