Open
Conversation
This is an extended version of QComboBox with a built in MenuHelper from OCIOv2. These menus are filtered based on config categories and sub menus are created by config familes.
These replace the previous default color space. If an OCIO config has the roles default_byte and default_float we use them. Otherwise we fall back onto OCIO::ROLE_DEAFULT.
Collaborator
Author
|
@itsmattkc sorry I've dropped this fo rso long. I've updated it to master and wondered if you could have a quick look. Probably needs some clean up but I'll mark it as not a draft. Exmaple of the colour space combobox below: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WIP set of colour related improvments:
default_floatanddefault_bytetypecie interchangespaceAny other ideas are welcome