You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements a RGB to B&W node using OCIO luma coefficients. ALso allows for overriding these with custom weights. There's a few questions in the code comments.
Specifically is there a good way to have coloured sliders be disabled and greyed out? I feel my solution is not ideal. Also I've tried to cache the luma coefficients but I can't seem to get it to work properly.
Not sure if you do this with this patch, but it may be wise to expose the weights and fill them with the default as determined. This would allow cases where folks may require alternative weighting.
@itsmattkc quick question, the title of this node is RGB to B&W which displays fine in the properties viewer. However, in the drop downs (e.g. the add effect drop down) Qt uses the & as an emphasis and so it displays as "RGB to BW" with the W underlined (see image). If I use a double ampersand to correct this it displays incorrectly in the node header. What do you think the best approach is here? Just using one ampersand and living with the underline o rmaybe even just ditching the ampersand completely?
Other than that I think this is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a RGB to B&W node using OCIO luma coefficients. ALso allows for overriding these with custom weights. There's a few questions in the code comments.
Specifically is there a good way to have coloured sliders be disabled and greyed out? I feel my solution is not ideal. Also I've tried to cache the luma coefficients but I can't seem to get it to work properly.