-
Notifications
You must be signed in to change notification settings - Fork 27
Harden Docker execution by running as non-root and fixing results permissions #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @olivierb46 ! My intention was to fix the Docker/runtime issues in a consistent way. If you’d prefer this split into smaller PRs, I’m more than happy to adjust it. I also have a few ideas in mind for future improvements, including the possibility of adding a small web-based interface, if that’s something you’d ever be interested in discussing. Thanks for your time and for maintaining the project. |
|
Hi @matiasAS This is my first repository on GitHub (I didn’t expect the project to attract so much attention), and I’m also learning as I go. Fortunately, I was able to quickly rely on the support of @GuyGuy-59. Thank you very much for the work you’re doing and for taking my remarks into account. Before moving toward a web interface, I’d like to consolidate the code and avoid going in too many directions 🙂. That said, I’m keeping your idea of a web interface in mind, which we could integrate as an option. I’ll take a look at your PR a bit later, as I’m currently preparing New Year’s Eve with my family 🙂. |
|
Ok @olivierb46 , no problem. I'm from Chile, do you speak Spanish? |
|
Great! But sorry — I’m afraid I haven’t spoken Spanish since my studies in the 90s :/ |
|
Ok @olivierb46 , in these latest changes I've corrected the Dockerfile and made some corrections to the code so that Docker execution without the root user works correctly. |
|
Hi @matiasAS, Thank you again for your suggestions; however, your PRs introduce many changes to the code. I prefer to move forward iteratively. I will start by integrating some of the changes, such as moving the md5sum.txt file into the output directory of each gateway rather than keeping it at the root of the program. Best regards |
|
Hi @olivierb46 , I understand it affects the file structure you want for your project, but I'll leave the idea here for you to use later if you want. It was a moment of inspiration, and I did it this way. Regards |
Main changes:
Motivation:
Notes: