Skip to content

Conversation

@matiasAS
Copy link
Contributor

Main changes:

  • Run the container using a non-privileged user (appuser).
  • Ensure generated files (CSV, md5sum.txt, graphs) are written under results// instead of the container root.
  • Align file paths with config.py to prevent permission errors in Docker.
  • Preserve full compatibility with non-Docker (local) execution.

Motivation:

  • Avoid running containers as root.
  • Follow Docker security best practices.
  • Prevent permission-related runtime errors.

Notes:

  • No business logic changes were introduced.
  • Changes are intentionally minimal and security-focused.
  • Additional structural improvements will be addressed in separate PRs.

@matiasAS
Copy link
Contributor Author

Hi @olivierb46 !
Just a quick note: I don’t have a lot of experience structuring pull requests yet, so apologies if this PR includes more files than strictly necessary.

My intention was to fix the Docker/runtime issues in a consistent way. If you’d prefer this split into smaller PRs, I’m more than happy to adjust it.

I also have a few ideas in mind for future improvements, including the possibility of adding a small web-based interface, if that’s something you’d ever be interested in discussing.

Thanks for your time and for maintaining the project.

@olivierb46
Copy link
Owner

Hi @matiasAS

This is my first repository on GitHub (I didn’t expect the project to attract so much attention), and I’m also learning as I go. Fortunately, I was able to quickly rely on the support of @GuyGuy-59.

Thank you very much for the work you’re doing and for taking my remarks into account. Before moving toward a web interface, I’d like to consolidate the code and avoid going in too many directions 🙂. That said, I’m keeping your idea of a web interface in mind, which we could integrate as an option.

I’ll take a look at your PR a bit later, as I’m currently preparing New Year’s Eve with my family 🙂.

@matiasAS
Copy link
Contributor Author

Ok @olivierb46 , no problem.

I'm from Chile, do you speak Spanish?

@olivierb46
Copy link
Owner

Great! But sorry — I’m afraid I haven’t spoken Spanish since my studies in the 90s :/

@matiasAS
Copy link
Contributor Author

Ok @olivierb46 , in these latest changes I've corrected the Dockerfile and made some corrections to the code so that Docker execution without the root user works correctly.

@olivierb46
Copy link
Owner

Hi @matiasAS,

Thank you again for your suggestions; however, your PRs introduce many changes to the code. I prefer to move forward iteratively. I will start by integrating some of the changes, such as moving the md5sum.txt file into the output directory of each gateway rather than keeping it at the root of the program.

Best regards

@matiasAS
Copy link
Contributor Author

matiasAS commented Jan 5, 2026

Hi @olivierb46 ,

I understand it affects the file structure you want for your project, but I'll leave the idea here for you to use later if you want. It was a moment of inspiration, and I did it this way.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants