Added One to Many Datatype Transformation for IT #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pawankashyapollion
commented
Jan 31, 2025
•
pawankashyapollion
commented
- Added One to Many Datatype Transformation for IT
- Fix PR review comments
taherkl
reviewed
Jan 31, 2025
|
|
||
| private long getRowCount() { | ||
| String query = String.format("SELECT COUNT(*) FROM %s", TABLE); | ||
| ResultSet resultSet = cassandraResourceManager.executeStatement(query); |
There was a problem hiding this comment.
executeStatement can throw exceptions as well...can add try catch on the function
There was a problem hiding this comment.
@taherkl we should not as even in case of exception test should fail the ideal case it should not throw any exception
| } | ||
| } | ||
|
|
||
| private void assertRowInCassandraDB() throws MultipleFailureException { |
There was a problem hiding this comment.
Add comments to all the functions
There was a problem hiding this comment.
Address the same
taherkl
requested changes
Feb 4, 2025
| @@ -25,14 +25,18 @@ | |||
| import com.google.gson.JsonObject; | |||
| import com.google.pubsub.v1.SubscriptionName; | |||
| import com.google.pubsub.v1.TopicName; | |||
| import java.io.IOException; | |||
| import java.io.*; | |||
There was a problem hiding this comment.
import * will fail the spotless check i guess
There was a problem hiding this comment.
Handle the same
| spannerResourceManager.write(m); | ||
| } | ||
|
|
||
| private void assertCustomRowsInCassandraDB() throws MultipleFailureException { |
There was a problem hiding this comment.
Make sure to add comments for all the functions.
There was a problem hiding this comment.
Addressed
taherkl
requested changes
Feb 5, 2025
| } | ||
| } | ||
|
|
||
| private void writeBasicRowInSpanner() { |
There was a problem hiding this comment.
This file does not have comments for functions
taherkl
approved these changes
Feb 5, 2025
taherkl
changed the title
pawankashyapollion
added a commit
that referenced
this pull request
Feb 13, 2025
…m#2155) * Add IT for Cassandra (#86) * Add IT for Cassandra Reverse Replication * Added IT Fixes * Added IT fixes * removed logger * removed unwanted system log * Handle Catch * Handle with safehandler * Running load test * revert unwanted commit * Added IT FIXES * Added UT and removed unwanted SOUT * Added One to Many Datatype Transformation for IT (#90) Added One to Many Datatype Transformation for IT Fix PR review comments * Handle IT for MYSQL * Added ByteBuffer TO BigInteger * Cassandra rr custom transfornation it test (#96) * PR Review Comments (#97) * Splotless fixes * Handle Retry Missing Exception Category * Rebase Issue fixes --------- Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.