This repository has been archived by the owner on Aug 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
Remove nonfunctional pom.xml. #272
Open
bimargulies-google
wants to merge
4
commits into
oltpbenchmark:master
Choose a base branch
from
bimargulies-google:kill-pom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove nonfunctional pom.xml. #272
bimargulies-google
wants to merge
4
commits into
oltpbenchmark:master
from
bimargulies-google:kill-pom
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How hard would it be to just fix this? |
There are not a lot of good ways in Maven to deal with the collection of
not-on-Maven-central dependencies. When the pom last worked, it was just
Oracle, but now it's more.
I could look at two strategies.
1: gradle instead of Maven.
2: taking all those JDBC drivers out of the Maven dependency graph. Nothing
should be referencing them at compile time anyway.
Which would you prefer?
…On Sat, Dec 15, 2018 at 8:44 AM Andy Pavlo ***@***.***> wrote:
How hard would it be to just fix this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX8h5bUr1GFoKUMqxFdUcGD-D1BClcIjks5u5Sb-gaJpZM4ZUK0n>
.
--
Benson Margulies
|
@bimargulies-google We should probably switch to gradle. This is something that we have talked about but just didn't have time to do it. |
I'll have myself a look.
…On Sat, Dec 15, 2018 at 9:55 AM Andy Pavlo ***@***.***> wrote:
@bimargulies-google <https://github.com/bimargulies-google> We should
probably switch to gradle. This is something that we have talked about but
just didn't have time to do it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX8h5Xf3c8y88n4fQzC5OkpEIg3XiYhoks5u5TeCgaJpZM4ZUK0n>
.
--
Benson Margulies
|
I've got a gradle build. There's some cleanup if you want to commit to it -- deleting almost all of 'lib', and fixing up travis. To try it: gradle installDist ./dist/bin/oltpbenchmark -b tpch -c config/tpch_sqlite.xml --create=true --load=true --execute=true -s 5 -o outputfile Unfortunately, this hits an NPE even with the ant build on master, so I can't tell for sure that I've got all this sorted. Ideas? |
@bimargulies-google Thanks for doing this. Can you be more specific about how to reproduce the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.