Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make work on Rocky Linux 9 #10

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Make work on Rocky Linux 9 #10

merged 6 commits into from
Jan 15, 2024

Conversation

pwalczysko
Copy link
Member

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the role changes look minimal and sensible
  • same comment as other PRs, GitHub Actions need to be re-enabled across all these repositories
  • the requirement of a dedicated destroy.yml step is slightly worrying. Are you anticipating this will be needed across all roles ?

@pwalczysko
Copy link
Member Author

  • the requirement of a dedicated destroy.yml step is slightly worrying. Are you anticipating this will be needed across all roles ?

Not sure. This is the first time ever that I saw the test failing on the "destroy" step. The error was inspecific, and the destroy.yml fixed it...
In a bigger scheme of things, adding such file to all repos is not a big prob, but I have no indication this is necessary as yet, see above.

@jburel
Copy link
Member

jburel commented Nov 1, 2023

The role depends on nfs-share
and nfs-share depends on nfs-mount
This makes the release difficult.
@sbesson @joshmoore Do you remember the logic?

@joshmoore
Copy link
Member

I do not. Sounds like something I would have tried hard to avoid.

@jburel jburel merged commit 66c98fa into ome:master Jan 15, 2024
3 checks passed
@pwalczysko pwalczysko deleted the Rocky9 branch January 15, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants