Skip to content

Build #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Build #193

merged 3 commits into from
Nov 25, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 20, 2024

Update actions and Update PyPI publish workflow to use build instead of sdist

@jburel jburel requested a review from sbesson November 24, 2024 21:35
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the workflow changes themselves make sense, the Python package is still marked as experimental via its name, its content has been unmodified in more than 3 years and I am unaware of any planned work.

This raises the question of whether the Python code under ome_model should be extracted into its own repository and maintained separately. This strategy would match what has been done for the C++ implementation (#111) as well as the Sphinx documentation (#174).

Listing for discussion at the weekly Formats meeting

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today, merging this and creating an issue to extract the code to a separate repository

@sbesson sbesson merged commit 908c6ef into ome:master Nov 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants